This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce XcmConversionError #5307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
KiChjang
commented
Apr 13, 2022
| CannotConvertBlob, | ||
| CannotConvertGeneralKey, | ||
| MaxAssetCountExceeded, | ||
| UnsupportedXcmErrorVariant, |
There was a problem hiding this comment.
I think I should use #[codec(index = $u8)] here to ensure that all enum variants have a well-defined SCALE encoding? I don't surmise that this enum would grow in the number of variants, but perhaps it's still a good practice to keep regardless?
This reverts commit ed00e09.
…-- benchmark pallet --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
…-- benchmark pallet --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/polkadot-sdk#920.
Create two new types
ConversionErrorandVersionedConversionErrorso that XCM APIs that attempt to convert from older versions of XCM to newer ones would throw aConversionErrorinstead of just().Each variant of the
ConversionErrorenum will indicate the reason why the error was thrown. TheVersionedConversionErrorenum is then used to wrap theConversionErrorinto one of its variants to indicate which version that the code was attempting to upgrade to threw an error.One of the design considerations here is that converting from newer versions to older versions will not generate a
ConversionError, and instead would still result in a catch-allUnsupportedVersionerror. This is so that we push people towards using newer XCM versions, instead of continually supporting older versions, because technically speaking, older version will indeed be unsupported as time goes by.