Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

upgrade coarsetime to 0.1.22 to fix a potential panic #5193

Merged
bkchr merged 3 commits into from
Mar 23, 2022
Merged

upgrade coarsetime to 0.1.22 to fix a potential panic #5193

bkchr merged 3 commits into from
Mar 23, 2022

Conversation

@drahnr
Copy link
Contributor

@drahnr drahnr commented Mar 23, 2022 •
edited
Loading

Currently there is a cfg switch that I misparsed to use the other branch. This unifies the two branches in jedisct1/rust-coarsetime#21 which has yet to make it into a release just made it into 0.1.22 .

@drahnr drahnr self-assigned this Mar 23, 2022
@drahnr drahnr added C1-low PR touches the given topic and has a low impact on builders. C3-medium PR touches the given topic and has a medium impact on builders. A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes and removed C1-low PR touches the given topic and has a low impact on builders. labels Mar 23, 2022
@drahnr drahnr changed the title use coarsetime-saturated for the time being upgrade coarsetime to 0.1.22 to fix a potential panic Mar 23, 2022
@drahnr
Copy link
Contributor Author

drahnr commented Mar 23, 2022

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Mar 23, 2022

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented Mar 23, 2022

Merge cancelled due to error. Error: Checks failed for 297178e

@drahnr drahnr added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Mar 23, 2022
@drahnr
Copy link
Contributor Author

drahnr commented Mar 23, 2022

bot merge

@ordian ordian added C1-low PR touches the given topic and has a low impact on builders. and removed C3-medium PR touches the given topic and has a medium impact on builders. labels Mar 23, 2022
@ordian
Copy link

ordian commented Mar 23, 2022

(changing the medium label to low because this dep wasn't present in 0.9.18 or prior)

@bkchr bkchr merged commit 6ec8ede into master Mar 23, 2022
@bkchr bkchr deleted the bernhard-coarsetime-fix branch March 23, 2022 18:34
@bkchr
Copy link
Member

bkchr commented Mar 23, 2022

(changing the medium label to low because this dep wasn't present in 0.9.18 or prior)

This panic would also only happen with debug-assertions enabled.

ordian pushed a commit that referenced this pull request Mar 24, 2022
Merge branch 'master' into ao-remove-old-migrations
b323434 
* master:
  Try to fix out of view statements (#5177)
  Companion for Substrate#11107 (#5197)
  paras: `include_pvf_check_statement` rt bench (#4938)
  [ci] Run short benchmarks only in PR pipelines (#5200)
  Companion for paritytech/substrate#10242 (#4862)
  [ci] Add short benchmarks to the pipeline (#5188)
  upgrade coarsetime to 0.1.22 to fix a potential panic (#5193)
  Update docs and enable DOT-over-XCM (#4809)
  enable disputes on all chains (#5182)
  companion for validator self-vote in bags (#5088)
  Extract MAX_FINALITY_LAG constant from relay_chain_selection (#5159)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@drahnr drahnr

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drahnr @ordian @bkchr