This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix build script for the builder image #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chevdor
added
A2-insubstantial
coderobe
reviewed
Mar 23, 2022
| @@ -8,17 +8,20 @@ PROJECT_ROOT=`git rev-parse --show-toplevel` | |||
| cd $PROJECT_ROOT | |||
|
|
|||
| # Find the current version from Cargo.toml | |||
| VERSION=`grep "^version" ./cli/Cargo.toml | egrep -o "([0-9\.]+)"` | |||
| VERSION=`grep "^version" ./cli/Cargo.toml | egrep -o "([0-9\.]+-?[0-9]+)"` | |||
There was a problem hiding this comment.
i would do something like this instead:
Suggested change
| VERSION=`grep "^version" ./cli/Cargo.toml | egrep -o "([0-9\.]+-?[0-9]+)"` | |
| VERSION=`grep "^version" ./cli/Cargo.toml | egrep -o "([0-9\.\-]+)"` |
There was a problem hiding this comment.
Why that ? Do you expect some 0.9-1.13 versions or something looking like that ?
There was a problem hiding this comment.
🤷♀️ Not necessarily, but shorter regexes are nicer for maintainability IMO.
Fine with either, really
coderobe
approved these changes
Mar 23, 2022
chevdor
added
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows handling versions with dash such as
v1.2.3-1.fix #4743