This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Collator protocol debug #5129
Merged
Collator protocol debug #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstakhov
added
A0-please_review
eskimor
reviewed
Mar 15, 2022
| @@ -662,6 +662,14 @@ async fn fetch_collation<Context>( | |||
|
|
|||
| if state.peer_data.get(&peer_id).map_or(false, |d| d.has_advertised(&relay_parent)) { | |||
| request_collation(ctx, state, relay_parent, para_id, peer_id, tx).await; | |||
| } else { | |||
There was a problem hiding this comment.
This does also trigger if there is no peer data for that peer.
There was a problem hiding this comment.
Yes, I think this message shoul be on the warn! level as it is quite unlikely.
rphmeier
approved these changes
Mar 16, 2022
|
bot merge |
sandreim
pushed a commit
that referenced
this pull request
Mar 16, 2022
* add two more timers * Update node/network/availability-recovery/src/metrics.rs * Try to improve comments spelling * Cargo fmt iteration * Add some presumably useful debugging for collator protocol * Address review comments Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to add some missing debug messages to the collator protocol part.