Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Approval-distribution: Fix out-of-view messages caused by a race condition in view updates #5089

Merged
merged 6 commits into from
Mar 14, 2022
Merged

Approval-distribution: Fix out-of-view messages caused by a race condition in view updates #5089

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a16c86a
Try to fix out-of-view messages in approval distribution
vstakhov Mar 11, 2022
8c1feb7
Cargo fmt
vstakhov Mar 11, 2022
10b8ed9
Add a unit test for the proposed fix
vstakhov Mar 14, 2022
383a5e5
Spelling fix
vstakhov Mar 14, 2022
d185659
Use a simplier approach to fix the race condition as suggested by @rp…
vstakhov Mar 14, 2022
84d88c5
Cargo fmt run
vstakhov Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Spelling fix
  • Loading branch information
@vstakhov
vstakhov committed Mar 14, 2022
commit 383a5e57b368037f38626fca6f2a0cb9833bc325
2 changes: 1 addition & 1 deletion node/network/approval-distribution/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ fn sends_assignments_even_when_state_is_approved() {
/// 1. Receive remote peer view update with an unknown head
/// 2. Receive assignments for that unknown head
/// 3. Update our view and import the new block
/// 4. Expect that no reputation with COST_UNEXPECTED_MESSAGE is applied
/// 4. Expect that no reputation with `COST_UNEXPECTED_MESSAGE` is applied
#[test]
fn race_condition_in_local_vs_remote_view_update() {
let parent_hash = Hash::repeat_byte(0xFF);
Expand Down