Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

paras: add governance control dispatchables #4575

Merged
merged 7 commits into from
Dec 29, 2021
Merged

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Dec 21, 2021

Part of #3211

Adds a couple of functions for governance control for the paras module
in the anticipation of PVF pre-checking enabling.

Specifically, this commit adds a function for pre-registering a PVF that
governance trusts enough. This function will come in handy in case there
is a parachain that does not follow the GoAhead signal. That is, does
not include paritytech/cumulus#517.

This may be not an exhaustive list of the functions that may come in
handy. Any suggestions to add more are welcome.

cc @bkchr @shawntabrizi

TODO:

  • kusama benchmarks
  • polkadot benchmarks
  • rococo benchmarks
  • westend

@pepyakin
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 21, 2021
@pepyakin pepyakin added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Dec 21, 2021
@pepyakin pepyakin added this to the v0.9.16 milestone Dec 21, 2021
@@ -1726,7 +1801,10 @@ impl<T: Config> Pallet<T> {
fn decrease_code_ref(code_hash: &ValidationCodeHash) -> Weight {
let mut weight = T::DbWeight::get().reads(1);
let refs = <Self as Store>::CodeByHashRefs::get(code_hash);
debug_assert!(refs != 0);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed just to pass an extra paranoid test: increase_code_ref_doesnt_have_allergy_on_add_trusted_validation_code

///
/// This function is mainly meant to be used for upgrading parachains that do not follow
/// the go-ahead signal while the PVF pre-checking feature is enabled.
#[pallet::weight(0)] // TODO:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to run benchmarks for this.

Adds a couple of functions for governance control for the paras module
in the anticipation of PVF pre-checking enabling.

Specifically, this commit adds a function for pre-registering a PVF that
governance trusts enough. This function will come in handy in case there
is a parachain that does not follow the GoAhead signal. That is, does
not include paritytech/cumulus#517.

This may be not an exhaustive list of the functions that may come in
handy. Any suggestions to add more are welcome.
@pepyakin
Copy link
Contributor Author

/benchmark runtime kusama runtime_parachains::paras

//
// NOTE That we do not use `increase_code_ref` here, because the code is not yet used
// by any parachain.
<Self as Store>::CodeByHash::insert(code_hash, &validation_code);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in this case, we completely ignore the onboarding/upgrade machinery? I guess that's fine/intended, but I would like to understand it better: Like how does the actual upgrade work then for example? Code is already on the relay chain, so what steps must a parachain do now to upgrade in this state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A parachain would attempt an upgrade. When that candidate is enacted, the inclusion module would call schedule_code_upgrade and then control will fall into kick_off_pvf_check and this branch will be taken.

From the parachain's standpoint, it will look like instant PVF approval or equally as good old pre-go-ahead signal upgrade.

Does this make sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep it does - thanks! So a parachain would still need to get it's full runtime upgrade through the backing phase, although the code is already on chain. We just bypass the voting, because we trust governance to have the code checked by some other means. 💡

@shawntabrizi
Copy link
Member

/benchmark runtime kusama runtime_parachains::paras

@parity-benchapp
Copy link

parity-benchapp bot commented Dec 28, 2021

Benchmark Runtime Kusama Pallet for branch "pep-pvf-paras-force-fns" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs

Results
Pallet: "runtime_parachains::paras", Extrinsic: "force_set_current_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras CurrentCodeHash (r:1 w:1)
Storage: Paras CodeByHashRefs (r:1 w:1)
Storage: Paras CodeByHash (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 2 + (0 * c)
Writes = 3 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1      37.7     0.248    0.6%
62915     209.2     0.561    0.2%
125829     369.6     0.617    0.1%
188743     522.4       1.4    0.2%
251657       678      0.52    0.0%
314571     832.7     1.441    0.1%
377485     988.6      1.32    0.1%
440399      1136     0.441    0.0%
503313      1295     1.672    0.1%
566227      1454     2.281    0.1%
629141      1618     4.025    0.2%
692055      1777     5.144    0.2%
754969      1943     4.785    0.2%
817883      2102     5.076    0.2%
880797      2259     4.748    0.2%
943711      2443     6.288    0.2%
1006625      2604      11.7    0.4%
1069539      2759     7.086    0.2%
1132453      2936     11.29    0.3%
1195367      3104      4.56    0.1%
1258281      3252     4.016    0.1%
1321195      3413     18.77    0.5%
1384109      3585     12.16    0.3%
1447023      3761     16.03    0.4%
1509937      3941     12.59    0.3%
1572851      4091     14.35    0.3%
1635765      4256     25.08    0.5%
1698679      4432     9.551    0.2%
1761593      4585     15.08    0.3%
1824507      4746     10.76    0.2%
1887421      4893     10.77    0.2%
1950335      5085     11.95    0.2%
2013249      5227     9.604    0.1%
2076163      5393     10.72    0.1%
2139077      5615     18.56    0.3%
2201991      5735     18.18    0.3%
2264905      5905     17.95    0.3%
2327819      6037     17.14    0.2%
2390733      6243     16.97    0.2%
2453647      6402     16.43    0.2%
2516561      6588     16.35    0.2%
2579475      6746     35.45    0.5%
2642389      6906     21.71    0.3%
2705303      7085     15.11    0.2%
2768217      7254     12.37    0.1%
2831131      7445     25.27    0.3%
2894045      7589     31.98    0.4%
2956959      7754     17.12    0.2%
3019873      7928     20.44    0.2%
3082787      8126     30.29    0.3%
3145701      8261     20.21    0.2%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 2 + (0 * c)
Writes = 3 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "force_set_current_head", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras Heads (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    16.49
    + s    0.001
              µs

Reads = 0 + (0 * s)
Writes = 1 + (0 * s)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    s   mean µs  sigma µs       %
    1     12.55     0.073    0.5%
20972      35.7     0.089    0.2%
41943     73.43     0.527    0.7%
62914     98.86      0.35    0.3%
83885     125.5     0.341    0.2%
104856     151.6     0.238    0.1%
125827     179.6     4.225    2.3%
146798     202.6     0.224    0.1%
167769     231.6     2.598    1.1%
188740     254.2     0.426    0.1%
209711     280.6     0.841    0.2%
230682       310     6.966    2.2%
251653     332.6     0.421    0.1%
272624     358.6     0.709    0.1%
293595     384.6     1.481    0.3%
314566     415.2     11.02    2.6%
335537     435.8     0.436    0.1%
356508     462.8     4.361    0.9%
377479     488.7      1.38    0.2%
398450     514.5     1.692    0.3%
419421       556     16.89    3.0%
440392     569.8     11.13    1.9%
461363     591.5     0.518    0.0%
482334     617.4     0.708    0.1%
503305     643.3     0.696    0.1%
524276     671.4     5.679    0.8%
545247     703.7     13.55    1.9%
566218     727.7     10.32    1.4%
587189     749.7      5.88    0.7%
608160     773.6      1.46    0.1%
629131     806.1     11.41    1.4%
650102     827.8     4.288    0.5%
671073     854.6     3.478    0.4%
692044     883.3     5.318    0.6%
713015     917.6     9.871    1.0%
733986     945.9     15.93    1.6%
754957     964.1     8.455    0.8%
775928     993.8     10.78    1.0%
796899      1023     10.31    1.0%
817870      1047     8.359    0.7%
838841      1093     15.02    1.3%
859812      1104     9.628    0.8%
880783      1144     14.79    1.2%
901754      1157     7.803    0.6%
922725      1177     4.276    0.3%
943696      1211     12.89    1.0%
964667      1248     12.27    0.9%
985638      1269     14.46    1.1%
1006609      1297      13.9    1.0%
1027580      1326     16.55    1.2%
1048551      1382     4.231    0.3%

Quality and confidence:
param     error
s             0

Model:
Time ~=     11.8
    + s    0.001
              µs

Reads = 0 + (0 * s)
Writes = 1 + (0 * s)

Pallet: "runtime_parachains::paras", Extrinsic: "force_schedule_code_upgrade", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: Paras FutureCodeHash (r:1 w:1)
Storage: Paras CurrentCodeHash (r:1 w:0)
Storage: Paras UpgradeCooldowns (r:1 w:1)
Storage: Paras PvfActiveVoteMap (r:1 w:0)
Storage: Paras CodeByHash (r:1 w:1)
Storage: Paras UpcomingUpgrades (r:1 w:1)
Storage: System Digest (r:1 w:1)
Storage: Paras CodeByHashRefs (r:1 w:1)
Storage: Paras FutureCodeUpgrades (r:0 w:1)
Storage: Paras UpgradeRestrictionSignal (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 9 + (0 * c)
Writes = 8 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1        78     0.478    0.6%
62915     243.6     0.336    0.1%
125829     403.3     0.578    0.1%
188743     555.8     1.038    0.1%
251657     712.7     1.754    0.2%
314571     853.7     10.69    1.2%
377485      1014     13.91    1.3%
440399      1154     6.868    0.5%
503313      1319     13.83    1.0%
566227      1471     15.14    1.0%
629141      1630     16.07    0.9%
692055      1788     18.02    1.0%
754969      1949     9.192    0.4%
817883      2076     10.06    0.4%
880797      2260     7.509    0.3%
943711      2408     10.03    0.4%
1006625      2566     13.21    0.5%
1069539      2713     12.97    0.4%
1132453      2893      16.8    0.5%
1195367      3044     11.83    0.3%
1258281      3218     7.007    0.2%
1321195      3388     13.25    0.3%
1384109      3534     11.88    0.3%
1447023      3717     16.56    0.4%
1509937      3885     26.22    0.6%
1572851      4034     14.69    0.3%
1635765      4230     12.58    0.2%
1698679      4387     13.84    0.3%
1761593      4589     15.28    0.3%
1824507      4727     14.52    0.3%
1887421      4898     12.94    0.2%
1950335      5048     15.72    0.3%
2013249      5216     14.24    0.2%
2076163      5474     26.01    0.4%
2139077      5545     11.83    0.2%
2201991      5731     20.19    0.3%
2264905      5897     32.35    0.5%
2327819      6049     23.57    0.3%
2390733      6219      15.5    0.2%
2453647      6424     11.68    0.1%
2516561      6664     17.66    0.2%
2579475      6739     17.86    0.2%
2642389      6886     6.953    0.1%
2705303      7050      19.7    0.2%
2768217      7207     16.84    0.2%
2831131      7370     17.24    0.2%
2894045      7569     22.95    0.3%
2956959      7757     37.81    0.4%
3019873      7901     24.02    0.3%
3082787      8064     21.47    0.2%
3145701      8235     26.48    0.3%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 9 + (0 * c)
Writes = 8 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "force_note_new_head", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras FutureCodeUpgrades (r:1 w:0)
Storage: Paras Heads (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    22.82
    + s    0.001
              µs

Reads = 1 + (0 * s)
Writes = 1 + (0 * s)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    s   mean µs  sigma µs       %
    1     17.58     0.145    0.8%
20972     40.05      0.08    0.1%
41943     79.36     0.263    0.3%
62914       105     0.316    0.3%
83885     131.3     0.211    0.1%
104856     158.4     0.305    0.1%
125827     184.7     0.323    0.1%
146798     208.9     0.265    0.1%
167769       235     0.267    0.1%
188740     261.2     0.183    0.0%
209711       287      0.19    0.0%
230682     313.5     0.268    0.0%
251653     339.6     0.322    0.0%
272624     365.1     0.406    0.1%
293595     391.2     0.332    0.0%
314566       417     0.182    0.0%
335537     446.2      10.1    2.2%
356508     471.1     7.246    1.5%
377479     497.1     6.734    1.3%
398450     520.6       0.4    0.0%
419421     547.1     0.425    0.0%
440392     582.6     14.75    2.5%
461363     601.4     6.092    1.0%
482334       631     11.44    1.8%
503305     653.8     8.632    1.3%
524276     676.6     0.315    0.0%
545247     703.4      0.33    0.0%
566218     737.5     11.64    1.5%
587189       762     12.03    1.5%
608160     799.8     14.49    1.8%
629131     811.1     5.849    0.7%
650102     850.2     14.36    1.6%
671073     870.3     13.99    1.6%
692044     898.8     12.34    1.3%
713015     923.4     12.25    1.3%
733986     953.6      14.3    1.5%
754957     979.7      13.3    1.3%
775928     999.5     8.775    0.8%
796899      1028     13.14    1.2%
817870      1071      19.7    1.8%
838841      1084     11.93    1.1%
859812      1116     13.29    1.1%
880783      1144     17.08    1.4%
901754      1172     15.97    1.3%
922725      1189     12.68    1.0%
943696      1216     9.698    0.7%
964667      1249     15.97    1.2%
985638      1277     13.96    1.0%
1006609      1306     13.73    1.0%
1027580      1332     17.13    1.2%
1048551      1364     14.25    1.0%

Quality and confidence:
param     error
s             0

Model:
Time ~=    18.65
    + s    0.001
              µs

Reads = 1 + (0 * s)
Writes = 1 + (0 * s)

Pallet: "runtime_parachains::paras", Extrinsic: "force_queue_action", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: ParasShared CurrentSessionIndex (r:1 w:0)
Storage: Paras ActionsQueue (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=     23.2
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=     23.2
              µs

Reads = 2
Writes = 1

Pallet: "runtime_parachains::paras", Extrinsic: "add_trusted_validation_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras PvfActiveVoteMap (r:1 w:0)
Storage: Paras CodeByHash (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 2 + (0 * c)
Writes = 1 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     7.478     0.055    0.7%
62915     175.5     0.307    0.1%
125829     328.4     0.601    0.1%
188743     475.8     0.317    0.0%
251657       629     0.997    0.1%
314571     784.5      9.42    1.2%
377485     948.3     14.45    1.5%
440399      1087     11.59    1.0%
503313      1246     13.12    1.0%
566227      1402     14.04    1.0%
629141      1550      12.6    0.8%
692055      1704     13.66    0.8%
754969      1858     14.93    0.8%
817883      2019        15    0.7%
880797      2171     15.45    0.7%
943711      2310     8.372    0.3%
1006625      2489     15.84    0.6%
1069539      2648     14.75    0.5%
1132453      2823     25.83    0.9%
1195367      2960     15.54    0.5%
1258281      3132     18.88    0.6%
1321195      3299     13.86    0.4%
1384109      3452      14.1    0.4%
1447023      3607     12.92    0.3%
1509937      3798     12.68    0.3%
1572851      3975     14.74    0.3%
1635765      4134     10.41    0.2%
1698679      4290     20.02    0.4%
1761593      4462     13.45    0.3%
1824507      4623     15.96    0.3%
1887421      4787     18.48    0.3%
1950335      4940     10.92    0.2%
2013249      5130     20.56    0.4%
2076163      5310     27.02    0.5%
2139077      5446      20.3    0.3%
2201991      5609     22.63    0.4%
2264905      5761     13.09    0.2%
2327819      5941     18.12    0.3%
2390733      6110      23.9    0.3%
2453647      6295      12.4    0.1%
2516561      6453     17.56    0.2%
2579475      6613     10.67    0.1%
2642389      6763     23.09    0.3%
2705303      6918     9.625    0.1%
2768217      7107     24.79    0.3%
2831131      7266     11.81    0.1%
2894045      7443     9.059    0.1%
2956959      7607     19.94    0.2%
3019873      7781     28.84    0.3%
3082787      7950     13.49    0.1%
3145701      8099     22.58    0.2%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 2 + (0 * c)
Writes = 1 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "poke_unused_validation_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras CodeByHashRefs (r:1 w:0)
Storage: Paras CodeByHash (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    4.639
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    4.639
              µs

Reads = 1
Writes = 1


Parity Bot added 2 commits December 28, 2021 23:24
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs
@pepyakin
Copy link
Contributor Author

/benchmark runtime polkadot runtime_parachains::paras

@parity-benchapp
Copy link

parity-benchapp bot commented Dec 29, 2021

Benchmark Runtime Polkadot Pallet for branch "pep-pvf-paras-force-fns" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras.rs

Results
Pallet: "runtime_parachains::paras", Extrinsic: "force_set_current_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras CurrentCodeHash (r:1 w:1)
Storage: Paras CodeByHashRefs (r:1 w:1)
Storage: Paras CodeByHash (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 2 + (0 * c)
Writes = 3 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     30.42     0.805    2.6%
62915     199.6     0.478    0.2%
125829     360.9     0.644    0.1%
188743     513.5     0.622    0.1%
251657       671     1.848    0.2%
314571     827.6     2.258    0.2%
377485     984.3     1.842    0.1%
440399      1141     2.262    0.1%
503313      1299     2.531    0.1%
566227      1457     1.766    0.1%
629141      1617     1.963    0.1%
692055      1784      5.37    0.3%
754969      1941     2.497    0.1%
817883      2098     2.638    0.1%
880797      2262     3.518    0.1%
943711      2420     10.67    0.4%
1006625      2589     8.706    0.3%
1069539      2756     4.931    0.1%
1132453      2914     10.49    0.3%
1195367      3066     4.872    0.1%
1258281      3239     14.91    0.4%
1321195      3420     8.888    0.2%
1384109      3585     19.31    0.5%
1447023      3751      13.8    0.3%
1509937      3912     12.04    0.3%
1572851      4066     9.543    0.2%
1635765      4232     18.94    0.4%
1698679      4408     18.33    0.4%
1761593      4633     21.41    0.4%
1824507      4704     11.68    0.2%
1887421      4896     27.09    0.5%
1950335      5053     28.13    0.5%
2013249      5220      11.4    0.2%
2076163      5371     19.53    0.3%
2139077      5554     18.67    0.3%
2201991      5712     18.58    0.3%
2264905      5893     27.47    0.4%
2327819      6048     17.26    0.2%
2390733      6224     29.05    0.4%
2453647      6380     29.14    0.4%
2516561      6560     12.16    0.1%
2579475      6727     29.92    0.4%
2642389      6923     23.11    0.3%
2705303      7085     20.64    0.2%
2768217      7250     19.98    0.2%
2831131      7408     22.83    0.3%
2894045      7576     19.18    0.2%
2956959      7780     25.45    0.3%
3019873      7930     16.21    0.2%
3082787      8076     19.49    0.2%
3145701      8253     26.11    0.3%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 2 + (0 * c)
Writes = 3 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "force_set_current_head", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras Heads (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.82
    + s    0.001
              µs

Reads = 0 + (0 * s)
Writes = 1 + (0 * s)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    s   mean µs  sigma µs       %
    1     12.76     0.121    0.9%
20972        36     0.058    0.1%
41943     73.94     0.156    0.2%
62914     99.03     0.344    0.3%
83885     126.2     0.277    0.2%
104856     152.9     0.467    0.3%
125827     181.4     1.733    0.9%
146798       205     4.144    2.0%
167769     229.6     0.386    0.1%
188740     255.5     0.397    0.1%
209711     281.7     0.489    0.1%
230682     309.9     2.437    0.7%
251653     333.7     0.682    0.2%
272624     359.5     0.492    0.1%
293595     386.7     1.186    0.3%
314566     411.9     0.822    0.1%
335537     437.8     1.064    0.2%
356508       466     5.347    1.1%
377479     489.8     0.939    0.1%
398450     516.3     1.422    0.2%
419421     541.5     0.366    0.0%
440392       571     9.966    1.7%
461363     593.9     1.124    0.1%
482334     620.3     1.122    0.1%
503305       648     8.295    1.2%
524276     678.7     11.22    1.6%
545247     698.3     0.797    0.1%
566218     726.5     3.549    0.4%
587189     753.3     8.833    1.1%
608160       784     12.07    1.5%
629131     807.8     10.28    1.2%
650102     844.6      16.5    1.9%
671073     871.3     15.51    1.7%
692044     886.8     11.06    1.2%
713015       918     10.02    1.0%
733986     935.5      2.74    0.2%
754957     965.3     11.23    1.1%
775928      1014     6.875    0.6%
796899      1032     14.62    1.4%
817870      1043     8.734    0.8%
838841      1069      10.5    0.9%
859812      1094     8.504    0.7%
880783      1124      9.09    0.8%
901754      1166     13.47    1.1%
922725      1183     10.77    0.9%
943696      1212     12.47    1.0%
964667      1234     10.77    0.8%
985638      1260     10.32    0.8%
1006609      1286     7.631    0.5%
1027580      1325     12.97    0.9%
1048551      1351     12.73    0.9%

Quality and confidence:
param     error
s             0

Model:
Time ~=    15.31
    + s    0.001
              µs

Reads = 0 + (0 * s)
Writes = 1 + (0 * s)

Pallet: "runtime_parachains::paras", Extrinsic: "force_schedule_code_upgrade", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: Paras FutureCodeHash (r:1 w:1)
Storage: Paras CurrentCodeHash (r:1 w:0)
Storage: Paras UpgradeCooldowns (r:1 w:1)
Storage: Paras PvfActiveVoteMap (r:1 w:0)
Storage: Paras CodeByHash (r:1 w:1)
Storage: Paras UpcomingUpgrades (r:1 w:1)
Storage: System Digest (r:1 w:1)
Storage: Paras CodeByHashRefs (r:1 w:1)
Storage: Paras FutureCodeUpgrades (r:0 w:1)
Storage: Paras UpgradeRestrictionSignal (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    2.205
    + c    0.002
              µs

Reads = 9 + (0 * c)
Writes = 8 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     77.36     0.281    0.3%
62915     240.1     0.299    0.1%
125829     396.3     0.613    0.1%
188743     545.3     0.608    0.1%
251657     698.6     1.203    0.1%
314571     857.3     12.77    1.4%
377485      1009     10.69    1.0%
440399      1164     12.03    1.0%
503313      1327     13.63    1.0%
566227      1471     13.95    0.9%
629141      1630     17.49    1.0%
692055      1769     7.533    0.4%
754969      1950     10.47    0.5%
817883      2089     16.32    0.7%
880797      2274     12.61    0.5%
943711      2408     15.35    0.6%
1006625      2573     4.651    0.1%
1069539      2733     17.05    0.6%
1132453      2896     12.22    0.4%
1195367      3053     9.891    0.3%
1258281      3219     12.33    0.3%
1321195      3446     18.33    0.5%
1384109      3611     8.621    0.2%
1447023      3732      13.1    0.3%
1509937      3882     13.72    0.3%
1572851      4053     15.01    0.3%
1635765      4212     10.33    0.2%
1698679      4376     20.25    0.4%
1761593      4561     11.91    0.2%
1824507      4720      9.96    0.2%
1887421      4908     8.555    0.1%
1950335      5047     15.77    0.3%
2013249      5211     12.04    0.2%
2076163      5373     19.83    0.3%
2139077      5521      11.9    0.2%
2201991      5735     28.67    0.5%
2264905      6004     8.282    0.1%
2327819      6068     19.04    0.3%
2390733      6227     19.77    0.3%
2453647      6382     8.523    0.1%
2516561      6573     18.26    0.2%
2579475      6747     20.72    0.3%
2642389      6897     12.05    0.1%
2705303      7083     24.86    0.3%
2768217      7223     22.03    0.3%
2831131      7407     23.47    0.3%
2894045      7567     30.92    0.4%
2956959      7751     15.02    0.1%
3019873      7902      26.8    0.3%
3082787      8070     19.36    0.2%
3145701      8232     24.51    0.2%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 9 + (0 * c)
Writes = 8 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "force_note_new_head", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras FutureCodeUpgrades (r:1 w:0)
Storage: Paras Heads (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.16
    + s    0.001
              µs

Reads = 1 + (0 * s)
Writes = 1 + (0 * s)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    s   mean µs  sigma µs       %
    1     17.58     0.101    0.5%
20972      40.8     0.381    0.9%
41943     79.32     0.206    0.2%
62914     104.6     0.282    0.2%
83885     134.5     0.767    0.5%
104856     158.2     0.254    0.1%
125827     184.7     0.387    0.2%
146798     209.2     0.152    0.0%
167769     235.5     0.292    0.1%
188740     261.4     0.376    0.1%
209711     287.7     0.396    0.1%
230682     313.3     0.386    0.1%
251653     339.9     0.384    0.1%
272624     365.5      0.27    0.0%
293595     391.6     0.267    0.0%
314566     417.5     0.363    0.0%
335537       445     4.166    0.9%
356508     469.5     0.537    0.1%
377479     497.6     5.703    1.1%
398450     532.1     3.223    0.6%
419421       548     1.473    0.2%
440392     577.7     10.99    1.9%
461363     599.7     0.559    0.0%
482334     635.3      14.8    2.3%
503305     657.1     9.498    1.4%
524276       684     12.09    1.7%
545247     708.9     10.39    1.4%
566218     738.5        13    1.7%
587189     762.5     13.22    1.7%
608160     782.5     0.387    0.0%
629131       809     0.582    0.0%
650102       841     10.15    1.2%
671073     873.6     14.42    1.6%
692044     913.5     7.691    0.8%
713015       918     8.783    0.9%
733986       944     5.606    0.5%
754957     971.1     6.793    0.6%
775928     997.3     5.469    0.5%
796899      1028     12.66    1.2%
817870      1057     13.28    1.2%
838841      1091     13.67    1.2%
859812      1110     12.23    1.1%
880783      1141     12.38    1.0%
901754      1167     12.71    1.0%
922725      1197     13.12    1.0%
943696      1224     13.51    1.1%
964667      1250     14.45    1.1%
985638      1276     10.96    0.8%
1006609      1314     17.24    1.3%
1027580      1327     6.351    0.4%
1048551      1369     17.62    1.2%

Quality and confidence:
param     error
s             0

Model:
Time ~=    19.18
    + s    0.001
              µs

Reads = 1 + (0 * s)
Writes = 1 + (0 * s)

Pallet: "runtime_parachains::paras", Extrinsic: "force_queue_action", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: ParasShared CurrentSessionIndex (r:1 w:0)
Storage: Paras ActionsQueue (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.66
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.66
              µs

Reads = 2
Writes = 1

Pallet: "runtime_parachains::paras", Extrinsic: "add_trusted_validation_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras PvfActiveVoteMap (r:1 w:0)
Storage: Paras CodeByHash (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 2 + (0 * c)
Writes = 1 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1       7.5     0.044    0.5%
62915     173.6     1.794    1.0%
125829       328     0.265    0.0%
188743     475.8     0.487    0.1%
251657     628.4     0.835    0.1%
314571     780.6     0.977    0.1%
377485     937.1     9.237    0.9%
440399      1100     15.52    1.4%
503313      1249     13.38    1.0%
566227      1402     15.39    1.0%
629141      1571      3.78    0.2%
692055      1711     14.87    0.8%
754969      1860     14.67    0.7%
817883      2027     10.59    0.5%
880797      2183     14.72    0.6%
943711      2350     7.761    0.3%
1006625      2486     13.97    0.5%
1069539      2659     6.622    0.2%
1132453      2805     13.05    0.4%
1195367      2978     10.57    0.3%
1258281      3137     8.676    0.2%
1321195      3313     11.25    0.3%
1384109      3473     13.29    0.3%
1447023      3641     13.67    0.3%
1509937      3791     17.11    0.4%
1572851      3975     20.63    0.5%
1635765      4228     12.12    0.2%
1698679      4301     11.18    0.2%
1761593      4464     11.56    0.2%
1824507      4612     14.55    0.3%
1887421      4792     26.08    0.5%
1950335      4971     13.03    0.2%
2013249      5125        10    0.1%
2076163      5294     18.03    0.3%
2139077      5458     21.53    0.3%
2201991      5601      8.38    0.1%
2264905      5777     8.568    0.1%
2327819      5963     14.98    0.2%
2390733      6141     22.52    0.3%
2453647      6283     19.11    0.3%
2516561      6466     26.53    0.4%
2579475      6613     14.01    0.2%
2642389      6795     26.41    0.3%
2705303      6949     29.24    0.4%
2768217      7117     23.92    0.3%
2831131      7284     28.65    0.3%
2894045      7457     26.28    0.3%
2956959      7610      19.8    0.2%
3019873      7785     19.83    0.2%
3082787      7931     17.79    0.2%
3145701      8127     28.31    0.3%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 2 + (0 * c)
Writes = 1 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "poke_unused_validation_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras CodeByHashRefs (r:1 w:0)
Storage: Paras CodeByHash (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    4.647
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    4.647
              µs

Reads = 1
Writes = 1


…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras.rs
@pepyakin
Copy link
Contributor Author

/benchmark runtime westend runtime_parachains::paras

@parity-benchapp
Copy link

parity-benchapp bot commented Dec 29, 2021

Benchmark Runtime Westend Pallet for branch "pep-pvf-paras-force-fns" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs

Results
Pallet: "runtime_parachains::paras", Extrinsic: "force_set_current_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras CurrentCodeHash (r:1 w:1)
Storage: Paras CodeByHashRefs (r:1 w:1)
Storage: Paras CodeByHash (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 2 + (0 * c)
Writes = 3 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     29.97      0.84    2.8%
62915     201.3     0.482    0.2%
125829     361.8     0.915    0.2%
188743     511.6     0.679    0.1%
251657     667.3     0.585    0.0%
314571     823.5     0.672    0.0%
377485     983.3     2.783    0.2%
440399      1137     1.734    0.1%
503313      1296     1.798    0.1%
566227      1455     1.928    0.1%
629141      1621     4.888    0.3%
692055      1772     2.619    0.1%
754969      1937     3.655    0.1%
817883      2092     3.815    0.1%
880797      2267     10.92    0.4%
943711      2426     9.838    0.4%
1006625      2598     6.336    0.2%
1069539      2751     5.624    0.2%
1132453      2909     11.44    0.3%
1195367      3062     10.18    0.3%
1258281      3242     15.16    0.4%
1321195      3411     12.36    0.3%
1384109      3581     17.15    0.4%
1447023      3754      10.1    0.2%
1509937      3913     10.91    0.2%
1572851      4073     18.02    0.4%
1635765      4237     14.21    0.3%
1698679      4399     16.16    0.3%
1761593      4561     14.84    0.3%
1824507      4721     17.62    0.3%
1887421      4907     11.82    0.2%
1950335      5107     11.24    0.2%
2013249      5213     19.14    0.3%
2076163      5381     14.82    0.2%
2139077      5611     21.51    0.3%
2201991      5695     9.502    0.1%
2264905      5871     20.39    0.3%
2327819      6017     26.94    0.4%
2390733      6208     19.14    0.3%
2453647      6395     12.49    0.1%
2516561      6553     24.99    0.3%
2579475      6741     17.41    0.2%
2642389      6896     17.85    0.2%
2705303      7045     18.14    0.2%
2768217      7224     18.73    0.2%
2831131      7389     15.58    0.2%
2894045      7540      7.84    0.1%
2956959      7744     22.42    0.2%
3019873      7912     18.36    0.2%
3082787      8248     88.08    1.0%
3145701      8268     36.62    0.4%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 2 + (0 * c)
Writes = 3 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "force_set_current_head", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras Heads (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    17.01
    + s    0.001
              µs

Reads = 0 + (0 * s)
Writes = 1 + (0 * s)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    s   mean µs  sigma µs       %
    1     12.48     0.073    0.5%
20972     35.63     0.146    0.4%
41943     73.84     0.303    0.4%
62914     99.96     0.899    0.8%
83885     125.9     0.151    0.1%
104856     155.4     1.305    0.8%
125827     179.1     0.219    0.1%
146798     203.1      0.57    0.2%
167769     230.2     4.197    1.8%
188740     255.3      0.71    0.2%
209711     282.5     3.818    1.3%
230682     306.6     0.796    0.2%
251653     332.8     0.411    0.1%
272624     358.5     0.619    0.1%
293595     384.9     1.364    0.3%
314566     412.1     1.717    0.4%
335537     436.3     0.491    0.1%
356508     462.1     0.532    0.1%
377479       490      4.62    0.9%
398450     514.1     0.655    0.1%
419421     540.2     0.657    0.1%
440392     572.3     10.39    1.8%
461363     598.5      12.1    2.0%
482334     622.4     7.764    1.2%
503305     646.9     4.893    0.7%
524276     669.9     1.483    0.2%
545247     696.4     1.524    0.2%
566218     723.7     5.052    0.6%
587189     748.5     1.555    0.2%
608160     784.5     13.81    1.7%
629131     802.5     1.346    0.1%
650102     827.6     1.545    0.1%
671073     872.2     14.45    1.6%
692044     883.4     8.621    0.9%
713015     913.7     8.898    0.9%
733986     943.3     12.96    1.3%
754957     975.3     14.04    1.4%
775928     995.3     13.37    1.3%
796899      1019     10.38    1.0%
817870      1042     7.634    0.7%
838841      1080     13.31    1.2%
859812      1105     12.47    1.1%
880783      1134     15.35    1.3%
901754      1155     11.63    1.0%
922725      1193     13.99    1.1%
943696      1209     4.554    0.3%
964667      1244     12.14    0.9%
985638      1275     14.96    1.1%
1006609      1306     16.33    1.2%
1027580      1327     14.13    1.0%
1048551      1354     14.51    1.0%

Quality and confidence:
param     error
s             0

Model:
Time ~=    12.59
    + s    0.001
              µs

Reads = 0 + (0 * s)
Writes = 1 + (0 * s)

Pallet: "runtime_parachains::paras", Extrinsic: "force_schedule_code_upgrade", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras FutureCodeHash (r:1 w:1)
Storage: Paras CurrentCodeHash (r:1 w:0)
Storage: Paras UpgradeCooldowns (r:1 w:1)
Storage: Paras PvfActiveVoteMap (r:1 w:0)
Storage: Paras CodeByHash (r:1 w:1)
Storage: Paras UpcomingUpgrades (r:1 w:1)
Storage: System Digest (r:1 w:1)
Storage: Paras CodeByHashRefs (r:1 w:1)
Storage: Paras FutureCodeUpgrades (r:0 w:1)
Storage: Paras UpgradeRestrictionSignal (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 8 + (0 * c)
Writes = 8 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     76.23     0.508    0.6%
62915       240      2.06    0.8%
125829       403      2.32    0.5%
188743     549.1     7.039    1.2%
251657     695.8     0.857    0.1%
314571     857.7     14.12    1.6%
377485      1014     15.18    1.4%
440399      1162     13.83    1.1%
503313      1315     15.07    1.1%
566227      1468     13.06    0.8%
629141      1621     15.26    0.9%
692055      1774     15.87    0.8%
754969      1938      14.4    0.7%
817883      2093     14.93    0.7%
880797      2256     8.122    0.3%
943711      2408      16.6    0.6%
1006625      2575     8.753    0.3%
1069539      2723      14.6    0.5%
1132453      2900     10.83    0.3%
1195367      3058     11.34    0.3%
1258281      3224     15.16    0.4%
1321195      3401     13.57    0.3%
1384109      3549     12.87    0.3%
1447023      3703     13.94    0.3%
1509937      3886     8.421    0.2%
1572851      4049     16.93    0.4%
1635765      4213      12.9    0.3%
1698679      4376     15.15    0.3%
1761593      4543     15.09    0.3%
1824507      4713     12.88    0.2%
1887421      4876     14.31    0.2%
1950335      5034     14.43    0.2%
2013249      5214     11.03    0.2%
2076163      5396     16.14    0.2%
2139077      5553     16.25    0.2%
2201991      5718     12.47    0.2%
2264905      5883     9.619    0.1%
2327819      6064     12.58    0.2%
2390733      6239     15.27    0.2%
2453647      6376     21.77    0.3%
2516561      6564        13    0.1%
2579475      6711     14.72    0.2%
2642389      6878     25.14    0.3%
2705303      7067     23.29    0.3%
2768217      7211     14.95    0.2%
2831131      7401     28.74    0.3%
2894045      7543     19.03    0.2%
2956959      7703     26.79    0.3%
3019873      7885     20.94    0.2%
3082787      8055     16.78    0.2%
3145701      8244     22.63    0.2%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 8 + (0 * c)
Writes = 8 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "force_note_new_head", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras FutureCodeUpgrades (r:1 w:0)
Storage: Paras Heads (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.49
    + s    0.001
              µs

Reads = 1 + (0 * s)
Writes = 1 + (0 * s)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    s   mean µs  sigma µs       %
    1     17.58     0.065    0.3%
20972     40.84     0.082    0.2%
41943      78.7     0.808    1.0%
62914     106.8     0.654    0.6%
83885     133.5     0.928    0.6%
104856     157.9     0.491    0.3%
125827     185.4     0.454    0.2%
146798     209.3     0.472    0.2%
167769     235.1      0.26    0.1%
188740     261.2     0.353    0.1%
209711     290.8     8.877    3.0%
230682     312.6     0.548    0.1%
251653     338.1     0.223    0.0%
272624     364.7     0.603    0.1%
293595     393.4     8.738    2.2%
314566     416.1     0.264    0.0%
335537     448.1     5.352    1.1%
356508     468.9     1.124    0.2%
377479       499     9.144    1.8%
398450     520.2     0.528    0.1%
419421     547.7     4.035    0.7%
440392     573.8       3.6    0.6%
461363     598.9     1.579    0.2%
482334       627     8.046    1.2%
503305     650.1     0.966    0.1%
524276     685.2     12.74    1.8%
545247       711     14.01    1.9%
566218     731.2     7.895    1.0%
587189     758.4     6.523    0.8%
608160     780.7     1.217    0.1%
629131     833.1     12.84    1.5%
650102     845.9     14.29    1.6%
671073     864.1     10.07    1.1%
692044     904.6     14.26    1.5%
713015     920.5     11.48    1.2%
733986     947.9     13.12    1.3%
754957     976.4     12.37    1.2%
775928     992.5     2.772    0.2%
796899      1021     9.383    0.9%
817870      1056     11.43    1.0%
838841      1083     13.81    1.2%
859812      1106     13.32    1.2%
880783      1142     13.08    1.1%
901754      1171     16.17    1.3%
922725      1185     9.451    0.7%
943696      1224     17.26    1.4%
964667      1246     14.92    1.1%
985638      1270     11.04    0.8%
1006609      1303     15.25    1.1%
1027580      1333     13.95    1.0%
1048551      1362     13.09    0.9%

Quality and confidence:
param     error
s             0

Model:
Time ~=    19.69
    + s    0.001
              µs

Reads = 1 + (0 * s)
Writes = 1 + (0 * s)

Pallet: "runtime_parachains::paras", Extrinsic: "force_queue_action", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: ParasShared CurrentSessionIndex (r:1 w:0)
Storage: Paras ActionsQueue (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.56
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.56
              µs

Reads = 2
Writes = 1

Pallet: "runtime_parachains::paras", Extrinsic: "add_trusted_validation_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras PvfActiveVoteMap (r:1 w:0)
Storage: Paras CodeByHash (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 2 + (0 * c)
Writes = 1 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     7.507     0.059    0.7%
62915     175.4     0.496    0.2%
125829     328.5     0.575    0.1%
188743     477.1     4.294    0.8%
251657     627.5     0.636    0.1%
314571     785.4     10.75    1.3%
377485     939.3     12.23    1.3%
440399      1095     15.35    1.4%
503313      1244     13.28    1.0%
566227      1409     14.04    0.9%
629141      1555     15.36    0.9%
692055      1701     14.15    0.8%
754969      1864     13.49    0.7%
817883      2012     14.85    0.7%
880797      2169     16.87    0.7%
943711      2318     14.23    0.6%
1006625      2498     4.828    0.1%
1069539      2652      16.6    0.6%
1132453      2801     13.96    0.4%
1195367      2961     13.82    0.4%
1258281      3139     13.28    0.4%
1321195      3286     10.53    0.3%
1384109      3459     17.99    0.5%
1447023      3619     10.04    0.2%
1509937      3789     7.222    0.1%
1572851      3950        15    0.3%
1635765      4127     9.127    0.2%
1698679      4303     14.54    0.3%
1761593      4454     23.15    0.5%
1824507      4645     19.98    0.4%
1887421      4885     6.895    0.1%
1950335      4945     16.06    0.3%
2013249      5123     18.31    0.3%
2076163      5303     22.76    0.4%
2139077      5479     32.89    0.6%
2201991      5636     17.62    0.3%
2264905      5786      15.2    0.2%
2327819      5960      17.1    0.2%
2390733      6129     14.15    0.2%
2453647      6278     26.93    0.4%
2516561      6437     13.69    0.2%
2579475      6638     33.42    0.5%
2642389      6760      19.1    0.2%
2705303      6950     16.58    0.2%
2768217      7111     24.15    0.3%
2831131      7278     34.25    0.4%
2894045      7452     18.96    0.2%
2956959      7607      45.1    0.5%
3019873      7775      15.8    0.2%
3082787      7933     12.19    0.1%
3145701      8117     21.27    0.2%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 2 + (0 * c)
Writes = 1 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "poke_unused_validation_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras CodeByHashRefs (r:1 w:0)
Storage: Paras CodeByHash (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    4.736
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    4.736
              µs

Reads = 1
Writes = 1


Parity Bot added 2 commits December 29, 2021 12:12
…k --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs
@pepyakin
Copy link
Contributor Author

/benchmark runtime custom --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs

@parity-benchapp
Copy link

parity-benchapp bot commented Dec 29, 2021

Benchmark Runtime Custom for branch "pep-pvf-paras-force-fns" with command cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs

Results
Pallet: "runtime_parachains::paras", Extrinsic: "force_set_current_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras CurrentCodeHash (r:1 w:1)
Storage: Paras CodeByHashRefs (r:1 w:1)
Storage: Paras CodeByHash (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 2 + (0 * c)
Writes = 3 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     28.79     0.269    0.9%
62915     198.9     0.485    0.2%
125829     359.1     0.641    0.1%
188743     512.4     0.493    0.0%
251657     667.6      0.65    0.0%
314571     823.3     1.581    0.1%
377485     978.5     1.624    0.1%
440399      1136     1.285    0.1%
503313      1294     1.586    0.1%
566227      1457     4.117    0.2%
629141      1613     2.932    0.1%
692055      1771     2.977    0.1%
754969      1933     2.662    0.1%
817883      2095     3.986    0.1%
880797      2258     3.342    0.1%
943711      2422     3.408    0.1%
1006625      2595     5.466    0.2%
1069539      2742     5.792    0.2%
1132453      2928     10.89    0.3%
1195367      3074     15.47    0.5%
1258281      3230      11.6    0.3%
1321195      3401        16    0.4%
1384109      3558     19.14    0.5%
1447023      3740     18.19    0.4%
1509937      3911     14.85    0.3%
1572851      4071     11.42    0.2%
1635765      4230     21.91    0.5%
1698679      4386     12.58    0.2%
1761593      4564     18.81    0.4%
1824507      4711     11.63    0.2%
1887421      4875      17.7    0.3%
1950335      5045     18.38    0.3%
2013249      5206     16.13    0.3%
2076163      5396     17.11    0.3%
2139077      5548     8.372    0.1%
2201991      5714      14.7    0.2%
2264905      5909      29.7    0.5%
2327819      6091     25.34    0.4%
2390733      6240     7.585    0.1%
2453647      6405     17.46    0.2%
2516561      6574     19.18    0.2%
2579475      6716     22.15    0.3%
2642389      6884     10.78    0.1%
2705303      7076     27.89    0.3%
2768217      7257     23.19    0.3%
2831131      7428     23.34    0.3%
2894045      7566     36.76    0.4%
2956959      7744     25.04    0.3%
3019873      7918     29.97    0.3%
3082787      8099     21.14    0.2%
3145701      8231     20.22    0.2%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 2 + (0 * c)
Writes = 3 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "force_set_current_head", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras Heads (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    17.34
    + s    0.001
              µs

Reads = 0 + (0 * s)
Writes = 1 + (0 * s)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    s   mean µs  sigma µs       %
    1     12.45     0.132    1.0%
20972     35.52     0.083    0.2%
41943     73.81     0.426    0.5%
62914     100.9     0.273    0.2%
83885     127.9     0.538    0.4%
104856     151.8     0.198    0.1%
125827     178.5     0.538    0.3%
146798     203.3     0.362    0.1%
167769     229.1     0.452    0.1%
188740     254.9     0.333    0.1%
209711       281     0.179    0.0%
230682     307.6     0.881    0.2%
251653     333.6     0.563    0.1%
272624       359     0.532    0.1%
293595       387     4.169    1.0%
314566     414.9     10.19    2.4%
335537     437.7     0.757    0.1%
356508     463.2     0.409    0.0%
377479     493.5     7.699    1.5%
398450     522.4     11.17    2.1%
419421     540.3      0.58    0.1%
440392     569.9     6.338    1.1%
461363     592.6     0.423    0.0%
482334     619.1      0.97    0.1%
503305     669.5     17.93    2.6%
524276     684.4      6.27    0.9%
545247     708.8     13.99    1.9%
566218       730     7.751    1.0%
587189     751.6     3.899    0.5%
608160     779.1      8.41    1.0%
629131     809.1     11.38    1.4%
650102     827.6     0.649    0.0%
671073     881.1      12.3    1.3%
692044       892      13.7    1.5%
713015     918.6     13.23    1.4%
733986     950.2        14    1.4%
754957     980.1     11.07    1.1%
775928     996.5     12.08    1.2%
796899      1024     13.84    1.3%
817870      1056     14.21    1.3%
838841      1082     16.86    1.5%
859812      1109     15.04    1.3%
880783      1140     15.26    1.3%
901754      1163     13.22    1.1%
922725      1185     13.69    1.1%
943696      1209      12.8    1.0%
964667      1238     11.78    0.9%
985638      1258     4.378    0.3%
1006609      1284     3.705    0.2%
1027580      1334     17.43    1.3%
1048551      1374      5.27    0.3%

Quality and confidence:
param     error
s             0

Model:
Time ~=    14.01
    + s    0.001
              µs

Reads = 0 + (0 * s)
Writes = 1 + (0 * s)

Pallet: "runtime_parachains::paras", Extrinsic: "force_schedule_code_upgrade", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Configuration ActiveConfig (r:1 w:0)
Storage: Paras FutureCodeHash (r:1 w:1)
Storage: Paras CurrentCodeHash (r:1 w:0)
Storage: Paras UpgradeCooldowns (r:1 w:1)
Storage: Paras PvfActiveVoteMap (r:1 w:0)
Storage: Paras CodeByHash (r:1 w:1)
Storage: Paras UpcomingUpgrades (r:1 w:1)
Storage: System Digest (r:1 w:1)
Storage: Paras CodeByHashRefs (r:1 w:1)
Storage: Paras FutureCodeUpgrades (r:0 w:1)
Storage: Paras UpgradeRestrictionSignal (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    0.617
    + c    0.002
              µs

Reads = 9 + (0 * c)
Writes = 8 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     76.46     0.251    0.3%
62915     238.6     0.445    0.1%
125829     395.4     0.389    0.0%
188743     546.5     4.127    0.7%
251657     698.9     4.145    0.5%
314571       851     3.879    0.4%
377485      1023     13.04    1.2%
440399      1154      4.53    0.3%
503313      1314     11.16    0.8%
566227      1478     12.25    0.8%
629141      1636     13.73    0.8%
692055      1781     17.63    0.9%
754969      1940     14.22    0.7%
817883      2095     16.18    0.7%
880797      2256     3.388    0.1%
943711      2401     11.51    0.4%
1006625      2565     11.16    0.4%
1069539      2755     16.65    0.6%
1132453      2903     10.35    0.3%
1195367      3060     10.41    0.3%
1258281      3213     13.73    0.4%
1321195      3392     18.42    0.5%
1384109      3547     14.41    0.4%
1447023      3705     14.27    0.3%
1509937      3952     5.856    0.1%
1572851      4052     9.493    0.2%
1635765      4203     8.739    0.2%
1698679      4386     12.13    0.2%
1761593      4541     16.24    0.3%
1824507      4710     12.55    0.2%
1887421      4890     16.33    0.3%
1950335      5045     15.73    0.3%
2013249      5203      11.1    0.2%
2076163      5368     17.78    0.3%
2139077      5575     21.47    0.3%
2201991      5707     12.64    0.2%
2264905      5894     23.04    0.3%
2327819      6062     20.41    0.3%
2390733      6288      37.5    0.5%
2453647      6398     34.98    0.5%
2516561      6546     12.53    0.1%
2579475      6730     20.06    0.2%
2642389      6879     12.43    0.1%
2705303      7055     30.34    0.4%
2768217      7228     16.68    0.2%
2831131      7391     21.19    0.2%
2894045      7541     13.94    0.1%
2956959      7720     15.51    0.2%
3019873      8005     18.05    0.2%
3082787      8061     17.49    0.2%
3145701      8237     9.435    0.1%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 9 + (0 * c)
Writes = 8 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "force_note_new_head", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras FutureCodeUpgrades (r:1 w:0)
Storage: Paras Heads (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    21.93
    + s    0.001
              µs

Reads = 1 + (0 * s)
Writes = 1 + (0 * s)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    s   mean µs  sigma µs       %
    1     16.99     0.108    0.6%
20972     40.37     0.104    0.2%
41943     77.25     0.285    0.3%
62914     106.7     0.325    0.3%
83885     131.6     1.071    0.8%
104856     157.4     0.314    0.1%
125827     183.9     0.302    0.1%
146798     208.2     0.262    0.1%
167769     234.3     0.318    0.1%
188740     260.4     0.522    0.2%
209711     285.8     0.259    0.0%
230682     311.9     0.343    0.1%
251653     338.1     0.266    0.0%
272624     364.5     0.971    0.2%
293595     389.8     0.226    0.0%
314566     416.3     0.292    0.0%
335537     442.3     1.014    0.2%
356508     468.1     0.747    0.1%
377479     494.1     0.761    0.1%
398450     531.5     17.83    3.3%
419421     549.1     8.686    1.5%
440392     572.6     0.639    0.1%
461363     599.3     4.922    0.8%
482334     623.6     0.438    0.0%
503305     651.6     1.835    0.2%
524276     677.3     0.964    0.1%
545247     702.2     0.671    0.0%
566218     731.3     9.665    1.3%
587189       762     13.41    1.7%
608160       780     3.856    0.4%
629131     810.1     5.676    0.7%
650102     844.2     16.21    1.9%
671073     869.7     13.74    1.5%
692044     890.5     7.869    0.8%
713015     911.6     2.266    0.2%
733986     941.5     4.596    0.4%
754957     971.3     12.17    1.2%
775928     999.5     11.24    1.1%
796899      1029     12.58    1.2%
817870      1049     5.877    0.5%
838841      1085     12.04    1.1%
859812      1100      1.19    0.1%
880783      1139     13.02    1.1%
901754      1165     13.55    1.1%
922725      1195     14.62    1.2%
943696      1216     10.19    0.8%
964667      1250     15.94    1.2%
985638      1278     15.87    1.2%
1006609      1307     13.93    1.0%
1027580      1342     13.57    1.0%
1048551      1360     11.21    0.8%

Quality and confidence:
param     error
s             0

Model:
Time ~=    17.58
    + s    0.001
              µs

Reads = 1 + (0 * s)
Writes = 1 + (0 * s)

Pallet: "runtime_parachains::paras", Extrinsic: "force_queue_action", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: ParasShared CurrentSessionIndex (r:1 w:0)
Storage: Paras ActionsQueue (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.31
              µs

Reads = 2
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    23.31
              µs

Reads = 2
Writes = 1

Pallet: "runtime_parachains::paras", Extrinsic: "add_trusted_validation_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras PvfActiveVoteMap (r:1 w:0)
Storage: Paras CodeByHash (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=        0
    + c    0.002
              µs

Reads = 2 + (0 * c)
Writes = 1 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    1     7.304     0.085    1.1%
62915     175.3     0.445    0.2%
125829     327.3     0.494    0.1%
188743     476.1      3.94    0.8%
251657     633.5     10.35    1.6%
314571       784      10.2    1.3%
377485     936.5      10.8    1.1%
440399      1087     13.83    1.2%
503313      1256     13.88    1.1%
566227      1398     14.17    1.0%
629141      1555     16.15    1.0%
692055      1720     8.998    0.5%
754969      1869     13.53    0.7%
817883      2006     13.67    0.6%
880797      2176     12.09    0.5%
943711      2330     13.11    0.5%
1006625      2497     14.99    0.6%
1069539      2657     22.11    0.8%
1132453      2808     11.57    0.4%
1195367      2963     10.72    0.3%
1258281      3135     11.05    0.3%
1321195      3313     19.25    0.5%
1384109      3487     21.95    0.6%
1447023      3674      26.2    0.7%
1509937      3800     11.27    0.2%
1572851      3941     14.97    0.3%
1635765      4121     16.57    0.4%
1698679      4304     22.77    0.5%
1761593      4471     19.14    0.4%
1824507      4626     19.41    0.4%
1887421      4807     15.72    0.3%
1950335      4964     20.71    0.4%
2013249      5121     22.72    0.4%
2076163      5281     16.36    0.3%
2139077      5474     15.37    0.2%
2201991      5631     27.86    0.4%
2264905      5799     24.75    0.4%
2327819      5947     19.12    0.3%
2390733      6097      14.7    0.2%
2453647      6294     22.35    0.3%
2516561      6465     19.35    0.2%
2579475      6637      32.9    0.4%
2642389      6799      36.8    0.5%
2705303      6952     16.87    0.2%
2768217      7131     21.72    0.3%
2831131      7289     12.47    0.1%
2894045      7437     14.33    0.1%
2956959      7634     34.11    0.4%
3019873      7801     20.98    0.2%
3082787      7963     23.02    0.2%
3145701      8122     9.865    0.1%

Quality and confidence:
param     error
c             0

Model:
Time ~=        0
    + c    0.003
              µs

Reads = 2 + (0 * c)
Writes = 1 + (0 * c)

Pallet: "runtime_parachains::paras", Extrinsic: "poke_unused_validation_code", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Paras CodeByHashRefs (r:1 w:0)
Storage: Paras CodeByHash (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    4.372
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    4.372
              µs

Reads = 1
Writes = 1


…k --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs
@pepyakin pepyakin merged commit 6a68473 into master Dec 29, 2021
@pepyakin pepyakin deleted the pep-pvf-paras-force-fns branch December 29, 2021 14:42
ordian added a commit that referenced this pull request Jan 3, 2022
* master:
  Set CurrentCodeHash before running some dispatchable benchmarks (#4645)
  paras: split tests (#4636)
  Bump quote from 1.0.10 to 1.0.14 (#4632)
  Bump pin-project from 1.0.8 to 1.0.9 (#4606)
  chore: fix copy&paste and tidy comments (#4646)
  derive Copy and Clone for Upgrade signals (#4637) (#4647)
  paras: fix upgrade restriction signal (#4603)
  configuration: Rename validation_upgrade_{frequency -> cooldown} (#4635)
  Bump lru from 0.7.1 to 0.7.2 (#4633)
  paras: add governance control dispatchables (#4575)
drahnr pushed a commit that referenced this pull request Jan 4, 2022
* paras: add governance control dispatchables

Adds a couple of functions for governance control for the paras module
in the anticipation of PVF pre-checking enabling.

Specifically, this commit adds a function for pre-registering a PVF that
governance trusts enough. This function will come in handy in case there
is a parachain that does not follow the GoAhead signal. That is, does
not include paritytech/cumulus#517.

This may be not an exhaustive list of the functions that may come in
handy. Any suggestions to add more are welcome.

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs

Co-authored-by: Parity Bot <admin@parity.io>
@jakoblell jakoblell added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jan 18, 2022
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
* paras: add governance control dispatchables

Adds a couple of functions for governance control for the paras module
in the anticipation of PVF pre-checking enabling.

Specifically, this commit adds a function for pre-registering a PVF that
governance trusts enough. This function will come in handy in case there
is a parachain that does not follow the GoAhead signal. That is, does
not include paritytech/cumulus#517.

This may be not an exhaustive list of the functions that may come in
handy. Any suggestions to add more are welcome.

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs

* cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs

Co-authored-by: Parity Bot <admin@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants