This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Log info about low connectivity and unreachable validators #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
added
A0-please_review
ordian
approved these changes
Sep 24, 2021
ordian
added a commit
that referenced
this pull request
Sep 28, 2021
* master: Log info about low connectivity and unreachable validators (#3916)
17 tasks
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done every ten minutes. If connectivity is considered low a warning is triggered as well.
I tried a few ways of implementing this, in the end the easiest was to do it in gossip support and do authority discovery directly there. We have a new message
ConnectToResolvedValidatorsnow, in case the caller resolved the addresses by himself already.In order for gossip support to be able to actually track active connections, I introduced an uninhabitated fake network message
GossipSuppportNetworkMessage, so we get informed about connect/disconnect events by the network bridge.I also removed
Statefrom gossip support and added its members into the subsystem directly. This made initialization with the authority discovery service more straight forward.