This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
update BaseXcmWeight to match Kusama #3911
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
changed the title
shawntabrizi
added
C1-low
shawntabrizi
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
This is fine, but I will say, that probably whatever end to end experiences you are building, you will need to have some system to actually read the weight of the corresponding XCM functions, since they may change over time.
So hard coding any values may not be the right long term thing.
But I agree, no reason for this to be different in the context of the different runtimes.
|
I think Gav have some plan on exposing some weight crates? But otherwise currently I don't see how we can do that. We definitely need a better long term solution. |
|
There is this issue logged for an xcm payment_queryInfo-like hook - paritytech/polkadot-sdk#969 |
apopiak
approved these changes
Sep 23, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
ordian
added a commit
that referenced
this pull request
Sep 28, 2021
* master: (24 commits) Added multisig in Rococo (#3873) Fix bin-substrate toml (#3939) Bump tracing from 0.1.27 to 0.1.28 (#3937) XCM Benchmarks for Asset Transactor w/ Fungible Asset (#3818) Bump libc from 0.2.101 to 0.2.102 (#3933) Do not compile `wasm_api` module when not needed. (#3934) Bump syn from 1.0.76 to 1.0.77 (#3932) Fix spelling (#3845) Bump tokio from 1.11.0 to 1.12.0 (#3910) Ignore `generate-bags` by dependabot (#3930) Update logging in paras_inherent (#3927) Bump libsecp256k1 from 0.6.0 to 0.7.0 (#3909) Remove BEEFY repo dependency (#3923) Substrate Companion for rust 1.54 (#3807) Fix broken links (#3919) update BaseXcmWegiht to match Kusama (#3911) add parachains pallets to Polkadot runtime (#3815) Add a `force_unfreeze` extrinsic to the disputes module (#3906) Add new rococo chainspec (#3905) Ensure all parachain configuration extrinsics are operational (#3912) ...
17 tasks
19 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why they are different? This makes testing impossible because testing environment is not same as production environment (Kusama).
Code works on Westend / Rococo means nothing if it is going to work on Kusama.
There are no way to access those value from parachain runtime so we need to hardcode the number and this just makes everything harder for parachains with zero benefits.