Set new staking limits #3299
Set new staking limits #3299
Conversation
kianenigma
added
B7-runtimenoteworthy
D5-nicetohaveaudit ⚠️
|
Will set some values for westend as well, as it will allow us to test stuff. |
| <pallet_staking::MinNominatorBond<Runtime>>::put(1 * UNITS); | ||
| <pallet_staking::MaxNominatorsCount<Runtime>>::put(1000); | ||
| <pallet_staking::MinValidatorBond<Runtime>>::put(10 * UNITS); | ||
| <pallet_staking::MaxValidatorsCount<Runtime>>::put(10); |
There was a problem hiding this comment.
We want to make westend more complex than polkadot in order to detect issues in the future.
We should have no limits here
There was a problem hiding this comment.
I preferred some limits here, and I set them intentionally low, such that we can try chilling others there.
|
bot merge |
|
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json. Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
|
Co-authored-by: Gavin Wood <gavin@parity.io>
* Set staking limits * Set westend limits as well * Update runtime/kusama/src/lib.rs Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: Gavin Wood <gavin@parity.io>
* Set staking limits * Set westend limits as well * Update runtime/kusama/src/lib.rs Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: Gavin Wood <gavin@parity.io>
| let min_nominator_bond = UNITS / 10; | ||
| // The absolute maximum number of nominators. This number is set rather conservatively, and | ||
| // is expected to increase soon after this runtime upgrade via another governance proposal. | ||
| // The current Polkadot state has more than 30_000 nominators, therefore no other nominator |
There was a problem hiding this comment.
There are currently around 22418 active nominators on Polkadot, I wonder from where 30 000 number comes from?
There was a problem hiding this comment.
Its not about active nominators, its about number of nominators in the underlying Nominators storage map.
There was a problem hiding this comment.
Its not about active nominators, its about number of nominators in the underlying
Nominatorsstorage map.
I see, thank you! So new nominators would not be able to start staking, or those who have higher stake would be stored, and this will be recalculated for each era?
There was a problem hiding this comment.
I would assume that only 20 000 with the highest stake will be counted
There was a problem hiding this comment.
This limit would make it so that only 20_000 accounts could exist in that nominators map. Once we hit that limit, other nominators would not be able to register.
cwerling
added
D1-audited 👍
No description provided.