This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix teleport accounting and add some events #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
pepyakin
reviewed
Jun 3, 2021
| } | ||
| } | ||
|
|
||
| /// Simple type used to identify messages for the purpose of reporting events. Secure if and only | ||
| /// if the message content is unique. | ||
| pub type MessageId = [u8; 32]; |
There was a problem hiding this comment.
If we care about this invariant, should it be a unit type with its own constructor?
There was a problem hiding this comment.
I'm not sure if that's actually enforcable in a useful way. It's really about the hashing algorithm, not the datatype, and we look after that by using blake2; this just corresponds to the output of that. In any case, I don't think it should block this PR.
shawntabrizi
approved these changes
Jun 3, 2021
pepyakin
approved these changes
Jun 3, 2021
mmostafas
added
D1-audited 👍
This was referenced Jun 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes a few renames to improve comprehensibility and readability.