Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Dispatchable for teleporting assets #2995

Merged
merged 9 commits into from
May 10, 2021
Merged

Dispatchable for teleporting assets #2995

merged 9 commits into from
May 10, 2021

Conversation

gavofyork
Copy link
Member

Added a dispatchable to make it a little easier to dispatch an asset by removing the need for a local weight payment in XCM.

@gavofyork gavofyork added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels May 7, 2021
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

xcm/src/v0/traits.rs Outdated Show resolved Hide resolved
xcm/pallet-xcm/src/lib.rs Show resolved Hide resolved

/// A means of getting approximate weight consumption for a given destination message executor and a
/// message.
pub trait UniversalWeigher {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read this from my phone so not 100% sure, but I can't find this trait being used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not referenced yet, but I expect it'll be useful in the future. Can remove if it offends.

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
xcm/src/v0/traits.rs Outdated Show resolved Hide resolved
@gavofyork gavofyork requested a review from shawntabrizi May 10, 2021 10:39
@gavofyork gavofyork merged commit 5851517 into master May 10, 2021
@gavofyork gavofyork deleted the gav-teleport-dispatch branch May 10, 2021 14:13
imstar15 pushed a commit to imstar15/polkadot that referenced this pull request Aug 25, 2021
…ytech#431)

* Companion paritytech#2995: Dispatchable for teleporting assets

* Fixes

* Fixes

* Fixes

* Fixes

* Bump Substrate

* Bump Polkadot

* Fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants