This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
labels
May 7, 2021
apopiak
reviewed
May 7, 2021
apopiak
reviewed
May 7, 2021
kianenigma
reviewed
May 8, 2021
kianenigma
approved these changes
May 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
kianenigma
reviewed
May 9, 2021
|
||
/// A means of getting approximate weight consumption for a given destination message executor and a | ||
/// message. | ||
pub trait UniversalWeigher { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read this from my phone so not 100% sure, but I can't find this trait being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's not referenced yet, but I expect it'll be useful in the future. Can remove if it offends.
shawntabrizi
reviewed
May 9, 2021
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
gavofyork
commented
May 10, 2021
imstar15
pushed a commit
to imstar15/polkadot
that referenced
this pull request
Aug 25, 2021
…ytech#431) * Companion paritytech#2995: Dispatchable for teleporting assets * Fixes * Fixes * Fixes * Fixes * Bump Substrate * Bump Polkadot * Fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a dispatchable to make it a little easier to dispatch an asset by removing the need for a local weight payment in XCM.