Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Augment Implementer's Guide XCMP docs #1569

Merged
3 commits merged into from
Aug 12, 2020
Merged

Augment Implementer's Guide XCMP docs #1569

3 commits merged into from
Aug 12, 2020

Conversation

danforbes
Copy link
Contributor

No description provided.

@danforbes danforbes requested a review from pepyakin August 11, 2020 20:24
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 11, 2020
@pepyakin pepyakin added C1-low PR touches the given topic and has a low impact on builders. B0-silent Changes should not be mentioned in any release notes labels Aug 12, 2020
pepyakin
pepyakin approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I made some adjustments though to move it forward (instead of blocking the merging), specifically: I removed the part about the third category, because XCMP AFAIU is a type of horizontal message passing. (Horizontal in this context means between the parachains).

Feel free to open a new PR if you feel that this should be still changed, I'm gonna go ahead and merge this one

@pepyakin
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Aug 12, 2020

Waiting for commit status.

@ghost ghost merged commit fb83176 into master Aug 12, 2020
@ghost ghost deleted the df-docs-xcmp branch August 12, 2020 10:02
ordian added a commit that referenced this pull request Aug 12, 2020
@ordian
Merge branch 'master' into ao-prometheus-metrics
fecef87 
* master:
  Network bridge refactoring impl (#1537)
  Augment Implementer's Guide XCMP docs (#1569)
  Support `build-spec` for other chains than Polkadot (#1567)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pepyakin pepyakin pepyakin approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danforbes @pepyakin