Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update comments in polkadot runtime #1445

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Update comments in polkadot runtime #1445

merged 1 commit into from
Jul 27, 2020

Conversation

joepetrowski
Copy link
Contributor

Was about to comment on 1443 when it got merged.

@joepetrowski joepetrowski added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 21, 2020
@gavofyork
Copy link
Member

wasm determinism failing? @gnunicorn ?

@gnunicorn
Copy link
Contributor

restarted. works now. worrying? maybe ... or, we just blame nightly...

@ordian ordian added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Jul 23, 2020
@bkchr bkchr merged commit 0ea96d1 into master Jul 27, 2020
@bkchr bkchr deleted the joe-runtime-comments branch July 27, 2020 10:51
@coriolinus coriolinus mentioned this pull request Jul 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork gavofyork approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joepetrowski @gavofyork @gnunicorn @ordian @bkchr