chore: release v1.0.0 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
Jun 1, 2023
gpestana
approved these changes
Jun 1, 2023
niklasad1
commented
Jun 2, 2023
| @@ -246,7 +246,7 @@ async fn runtime_upgrade_task(api: SubxtClient, tx: oneshot::Sender<Error>) { | |||
| log::info!(target: LOG_TARGET, "upgrade to version: {} successful", version); | |||
| }, | |||
| Err(e) => { | |||
| log::warn!(target: LOG_TARGET, "upgrade to version: {} failed: {:?}", version, e); | |||
| log::debug!(target: LOG_TARGET, "upgrade to version: {} failed: {:?}", version, e); | |||
There was a problem hiding this comment.
This will only fail if the applied update is the same as the current version.
Because substrate emit one at startup this will occur on every start so downgrading it debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #587