Skip to content

No disputes and no CandidateReceiptV2 on Kusama #8483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 10, 2025
Merged

No disputes and no CandidateReceiptV2 on Kusama #8483

merged 11 commits into from
May 10, 2025

Conversation

tdimitrov
Copy link
Contributor

@tdimitrov tdimitrov commented May 9, 2025 •
edited
Loading

This PR:

  • disables disputes
  • disables CandidateReceiptV2 node feature check
  • ensures the binary can be run only on Kusama

Update from @Overkillus :

Temporary patch to manage dispute overloading in Kusama. This is needed to apply the actual patch through the opengov referendum. This can then be reverted ASAP.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

s0me0ne-unkn0wn
s0me0ne-unkn0wn approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mary-santpere

@sandreim sandreim mentioned this pull request May 9, 2025
Open
@tdimitrov tdimitrov changed the title Disable disputes No disputes and no CandidateReceiptV2 on Kusama May 9, 2025
sandreim
sandreim approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Overkillus
Overkillus approved these changes May 10, 2025
View reviewed changes
Copy link
Contributor

@Overkillus Overkillus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

minor paranoid suggestion for the block height check

sandreim
sandreim approved these changes May 10, 2025
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bkchr bkchr added the R0-silent The change does not warrant a re-release of the modified crates. label May 10, 2025
sandreim
sandreim reviewed May 10, 2025
View reviewed changes
polkadot/cli/src/command.rs Outdated
@@ -190,6 +190,11 @@ where

set_default_ss58_version(chain_spec);

if !chain_spec.is_kusama() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have to allow testnets so zombienet test can run in CI ?

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/14939761371
Failed job name: test-linux-stable

@bkchr bkchr merged commit 98a3813 into stable2503 May 10, 2025
225 of 252 checks passed
@bkchr bkchr deleted the tsv-no-disputes2 branch May 10, 2025 01:05
eskimor added a commit that referenced this pull request May 13, 2025
@eskimor
Revert "No disputes and no CandidateReceiptV2 on Kusama (#8483)"
59928bf 
This reverts commit 98a3813.
@eskimor eskimor mentioned this pull request May 13, 2025
Merged
EgorPopelyaev pushed a commit that referenced this pull request May 13, 2025
@eskimor
Revert "No disputes and no CandidateReceiptV2 on Kusama" (#8506)
80e49a3 
Reverts #8483
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/2025-05-09-kusama-dispute-storm-postmortem/12947/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@Overkillus Overkillus Overkillus approved these changes

@s0me0ne-unkn0wn s0me0ne-unkn0wn s0me0ne-unkn0wn approved these changes

Assignees
No one assigned
Labels
R0-silent The change does not warrant a re-release of the modified crates.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tdimitrov @Polkadot-Forum @Overkillus @s0me0ne-unkn0wn @sandreim @bkchr