Skip to content

[stable2503] Backport #8351 #8464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025
Merged

Conversation

paritytech-release-backport-bot[bot]

Backport #8351 into stable2503 from wassimans.

See the documentation on how to use this bot.

…sitable dust (#8351)

# Description

This PR enhances the XCM executor’s `deposit_assets_with_retry` so that
**dust deposits** (below the chain’s existential deposit) no longer
abort the entire batch. Instead, any `TokenError::BelowMinimum` is
treated as non‐fatal: the dust portion is burned, and the executor
continues depositing the rest of the assets.
Once this lands, complex XCMs that transfer multiple assets will no
longer fail outright when the leftover fee asset after buying execution
becomes dust.

Fixes issue #4408

## Integration

No downstream runtime APIs are changed. Existing parachain and
relay‐chain integrations of the XCM executor will automatically benefit
from this fix without modification.
No deprecation or migration steps are required by users of
`XcmExecutor`.

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
(cherry picked from commit 7622917)
@paritytech-release-backport-bot paritytech-release-backport-bot bot requested a review from a team as a code owner May 7, 2025 13:15
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label May 7, 2025
@acatangiu acatangiu enabled auto-merge (squash) May 7, 2025 13:17
Copy link
Contributor

github-actions bot commented May 7, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@acatangiu acatangiu requested a review from a team May 7, 2025 14:38
@acatangiu acatangiu merged commit ed9e220 into stable2503 May 14, 2025
255 of 261 checks passed
@acatangiu acatangiu deleted the backport-8351-to-stable2503 branch May 14, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants