Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release|CI/CD] Update runtime artefact's name before upload to a GitHub draft release #7814

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

EgorPopelyaev
Copy link
Contributor

This PR is an improvement of the Create Release Draft workflow. Due to the switch to the direct use of gh to upload artefacts to the release draft, behaviour of it has slightly changed. gh renames only a display name of the file but not the file it self.
This pr adds renaming before the upload so that displayed name of the attachment and the file itself have the same name that includes spec_version in it.

Closes: https://github.com/paritytech/release-engineering/issues/250

cc: @BulatSaif

@EgorPopelyaev EgorPopelyaev added R0-silent Changes should not be mentioned in any release notes D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. A4-needs-backport Pull request must be backported to all maintained releases. labels Mar 6, 2025
@EgorPopelyaev EgorPopelyaev requested review from a team as code owners March 6, 2025 06:48
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 6, 2025 07:32
@EgorPopelyaev EgorPopelyaev enabled auto-merge March 6, 2025 09:40
@EgorPopelyaev EgorPopelyaev added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit 1396a75 Mar 6, 2025
243 of 251 checks passed
@EgorPopelyaev EgorPopelyaev deleted the ep-update-runtimes-name-before-upload branch March 6, 2025 15:01
@paritytech-release-backport-bot

Git push to origin failed for stable2407 with exitcode 1

@paritytech-release-backport-bot

Git push to origin failed for stable2409 with exitcode 1

@paritytech-release-backport-bot

Git push to origin failed for stable2412 with exitcode 1

@paritytech-release-backport-bot

Git push to origin failed for stable2503 with exitcode 1

EgorPopelyaev added a commit that referenced this pull request Mar 7, 2025
…Hub draft release (#7814)

This PR is an improvement of the Create Release Draft workflow. Due to
the switch to the direct use of `gh` to upload artefacts to the release
draft, behaviour of it has slightly changed. `gh` renames only a display
name of the file but not the file it self.
This pr adds renaming before the upload so that displayed name of the
attachment and the file itself have the same name that includes
`spec_version` in it.

Closes: paritytech/release-engineering#250

cc: @BulatSaif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants