-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release|CI/CD] Update runtime artefact's name before upload to a GitHub draft release #7814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ep-update-runtimes-name-before-upload
BulatSaif
approved these changes
Mar 6, 2025
AndWeHaveAPlan
approved these changes
Mar 6, 2025
alvicsam
approved these changes
Mar 6, 2025
Git push to origin failed for stable2407 with exitcode 1 |
Git push to origin failed for stable2409 with exitcode 1 |
Git push to origin failed for stable2412 with exitcode 1 |
Git push to origin failed for stable2503 with exitcode 1 |
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 7, 2025
…Hub draft release (#7814) This PR is an improvement of the Create Release Draft workflow. Due to the switch to the direct use of `gh` to upload artefacts to the release draft, behaviour of it has slightly changed. `gh` renames only a display name of the file but not the file it self. This pr adds renaming before the upload so that displayed name of the attachment and the file itself have the same name that includes `spec_version` in it. Closes: paritytech/release-engineering#250 cc: @BulatSaif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A4-needs-backport
Pull request must be backported to all maintained releases.
D0-easy
Can be fixed primarily by duplicating and adapting code by an intermediate coder.
R0-silent
Changes should not be mentioned in any release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an improvement of the Create Release Draft workflow. Due to the switch to the direct use of
gh
to upload artefacts to the release draft, behaviour of it has slightly changed.gh
renames only a display name of the file but not the file it self.This pr adds renaming before the upload so that displayed name of the attachment and the file itself have the same name that includes
spec_version
in it.Closes: https://github.com/paritytech/release-engineering/issues/250
cc: @BulatSaif