Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revive: Include immutable storage deposit into the contracts storage_base_deposit #7230

Merged
merged 54 commits into from
Feb 4, 2025
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
5966a01
Include immutable deposit in base deposit
athei Jan 7, 2025
ba7d704
Update from athei running command 'prdoc --audience runtime_dev'
Jan 18, 2025
1a6feb7
Remove left over debug logging
athei Jan 18, 2025
2f1a825
Correct prdoc bumps
athei Jan 18, 2025
131e622
Add ResetPallet
athei Jan 22, 2025
0d0ec0d
Merge branch 'master' into at/deposit
athei Jan 23, 2025
09b80be
Refine ResetRuntime
athei Jan 23, 2025
76bc3a3
Merge branch 'master' into at/deposit
athei Jan 23, 2025
d0f5327
Merge branch 'master' into at/deposit
athei Jan 23, 2025
1f2f51e
Update from athei running command 'bench-omni --runtime asset-hub-wes…
github-actions[bot] Jan 23, 2025
73d42f8
Update from athei running command 'bench-omni --dev --pallet pallet_r…
github-actions[bot] Jan 23, 2025
716c494
Merge branch 'master' into at/deposit
athei Jan 24, 2025
e833c2f
Make refcounting fallible
athei Jan 24, 2025
b8e4b31
No need to reference into the frame
athei Jan 24, 2025
0073daf
Update substrate/frame/revive/src/wasm/mod.rs
athei Jan 24, 2025
7f5ab96
Merge branch 'master' into at/deposit
athei Jan 24, 2025
7b492cb
Remove unused weight file
athei Jan 24, 2025
0b8c8a6
Merge branch 'master' into at/deposit
athei Jan 24, 2025
1dcc86d
Move ResetPallet to pallet_migration
athei Jan 24, 2025
8b49073
Add benchmark
athei Jan 24, 2025
e5ec326
Merge branch 'master' into at/deposit
athei Jan 25, 2025
e775901
Update from athei running command 'bench-omni --runtime asset-hub-wes…
github-actions[bot] Jan 25, 2025
52c4d34
Remove no longer needed 64bit check on call
athei Jan 25, 2025
abbbb7f
Manually add new weights to the substrate weight file
athei Jan 25, 2025
c998988
Manually add new benchmark to all runtimes
athei Jan 25, 2025
c137bd7
clippy: Simplify boolean expression
athei Jan 26, 2025
d273bbe
Use benchmarked weight in migration
athei Jan 26, 2025
99abd13
Use value size of 32bytes
athei Jan 27, 2025
a259955
Clippy
athei Jan 27, 2025
fee7935
Update docs
athei Jan 27, 2025
283d802
Merge branch 'master' into at/deposit
athei Jan 27, 2025
dba9a1f
Update from mordamax running command 'bench-omni --runtime dev asset-…
github-actions[bot] Jan 27, 2025
7585e2d
Merge branch 'master' into at/deposit
athei Jan 27, 2025
3091457
Import `frame` is necessary for benchmark template
athei Jan 27, 2025
bb2dfc7
Update from athei running command 'fmt'
github-actions[bot] Jan 27, 2025
d5a7b0b
Merge branch 'master' into at/deposit
athei Jan 28, 2025
551bb9b
Return correct amount of weight when erroring out early
athei Jan 28, 2025
9abc232
Remove not needed GenesisBuild functionality
athei Jan 28, 2025
e13c470
Add stricter check in try-runtime
athei Jan 28, 2025
52537b4
Apply suggestions from code review
athei Jan 28, 2025
e507e92
Fixes after applying suggestions
athei Jan 28, 2025
740876f
Merge branch 'master' into at/deposit
athei Feb 3, 2025
9017422
Use try_consume
athei Feb 3, 2025
2ebf592
Update substrate/frame/migrations/src/migrations.rs
athei Feb 3, 2025
bf284d4
Fix benchmarking assertions
athei Feb 3, 2025
a0123d2
Don't use OnGenesis
athei Feb 3, 2025
c8febcf
Add checks back to benchmarks
athei Feb 4, 2025
3d5b9b5
Merge branch 'master' into at/deposit
athei Feb 4, 2025
1efd67d
Update from athei running command 'fmt'
github-actions[bot] Feb 4, 2025
a5c6d27
Remove commit because the benchmarking infra does this
athei Feb 4, 2025
9d00085
Fix warning
athei Feb 4, 2025
3726ddf
Don't add new trait
athei Feb 4, 2025
cfbfdfd
Merge branch 'master' into at/deposit
athei Feb 4, 2025
ff02ca0
Update from athei running command 'bench --runtime dev --pallet palle…
github-actions[bot] Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes after applying suggestions
  • Loading branch information
athei committed Jan 28, 2025
commit e507e92570fad338b1404885d20357463fa760b8
6 changes: 3 additions & 3 deletions substrate/frame/migrations/src/migrations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ where
{
#[cfg(feature = "try-runtime")]
fn num_keys() -> u64 {
let prefix = Self::name_hash().to_vec();
let prefix = P::name_hash().to_vec();
crate::storage::KeyPrefixIterator::new(prefix.clone(), prefix, |_| Ok(())).count() as _
}
}
Expand Down Expand Up @@ -88,7 +88,7 @@ where
.remaining()
.saturating_sub(base_weight)
.checked_div_per_component(&weight_per_key)
.unwrap_or(Zero::zero())
.unwrap_or_default()
.saturated_into();

if key_budget == 0 {
Expand All @@ -97,7 +97,7 @@ where
})
}

let (keys_removed, is_done) = match clear_prefix(&Self::hashed_prefix(), Some(key_budget)) {
let (keys_removed, is_done) = match clear_prefix(&P::name_hash(), Some(key_budget)) {
KillStorageResult::AllRemoved(value) => (value, true),
KillStorageResult::SomeRemaining(value) => (value, false),
};
Expand Down
Loading