Add BlockNumberProvider to salary pallet config #7000
Conversation
PolkadotDom
changed the title
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "collectives-westend-runtime" | |||
| version = "3.0.0" | |||
| version = "3.1.0" | |||
There was a problem hiding this comment.
same as the other PR, I think crate versions are handled upon release with prdoc information
| /// local moment in time (system block number) | ||
| fn equivalent_moment_in_time(local: SalaryLocalBlockNumber) -> SalaryNewBlockNumber { | ||
| let block_number = System::block_number(); | ||
| let local_duration = block_number.saturating_sub(local); |
There was a problem hiding this comment.
same maybe better to make it general if local > block_number, to be safe if this code gets copied and pasted.
| where | ||
| BC: ConvertBlockNumber<LocalBlockNumberFor<T>, NewBlockNumberFor<T, I>>, | ||
| { | ||
| fn on_runtime_upgrade() -> frame_support::weights::Weight { |
There was a problem hiding this comment.
could be better to implement some pre_upgrade and post_upgrade ensuring that Status value is some if it was some, and claimant count is same before and after the migration.
| @@ -126,7 +128,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| spec_name: alloc::borrow::Cow::Borrowed("collectives-westend"), | |||
| impl_name: alloc::borrow::Cow::Borrowed("collectives-westend"), | |||
| authoring_version: 1, | |||
| spec_version: 1_017_001, | |||
| spec_version: 1_018_000, | |||
There was a problem hiding this comment.
I think these are bumped in the release branches, or in special merge requests, but not here.
| @@ -177,7 +177,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| // implementation changes and behavior does not, then leave spec_version as | |||
| // is and increment impl_version. | |||
| spec_version: 268, | |||
| impl_version: 0, | |||
| impl_version: 1, | |||
There was a problem hiding this comment.
| impl_version: 1, | |
| impl_version: 0, |
The kitchensink runtime needs to bumping.
| /// Provides the current block number. | ||
| /// | ||
| /// This is usually `cumulus_pallet_parachain_system::RelaychainDataProvider` if a | ||
| /// parachain, or `frame_system::Pallet` if a solochain. |
There was a problem hiding this comment.
| /// parachain, or `frame_system::Pallet` if a solochain. | |
| /// parachain, or `frame_system::Pallet` if a solo- or relaychain. |
|
|
||
| /// Converts previous (local) block number into the new one. May just be identity functions | ||
| /// if sticking with local block number as the provider. | ||
| pub trait ConvertBlockNumber<L, N> { |
There was a problem hiding this comment.
Can you put some example in the doc of this please? Just some pseudo code of how it is supposed to be called.
I can imagine it is easy to call it the other way around of how its meant to be 🙈
| use super::{BlockNumberFor as NewBlockNumberFor, *}; | ||
| use frame_system::pallet_prelude::BlockNumberFor as LocalBlockNumberFor; | ||
|
|
||
| /// Converts previous (local) block number into the new one. May just be identity functions |
There was a problem hiding this comment.
| /// Converts previous (local) block number into the new one. May just be identity functions | |
| /// Converts old block number into the new one. May just be identity functions |
Is there an inherent local/remote duality, or is it just old/new?
| /// | ||
| /// For instance - if your new version uses the relay chain number, you'll want to | ||
| /// use relay current - ((current local - local) * equivalent_block_duration) | ||
| fn equivalent_moment_in_time(local: L) -> N; |
There was a problem hiding this comment.
Can you put some example in the doc of this please? Just some pseudo code of how it is supposed to be called.
I can imagine it is easy to call it the other way around of how its meant to be 🙈
Following #3617, salary pallet is to be made async backing friendly. This PR adds the block number provider config parameter to pallet-salary.
In addition it
TODO:
Once Westend is updated I will write the migration for polkadot collectives.
@xlc