Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] net/discovery: Remove legacy /kad protocol #6109

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Oct 17, 2024

This PR removes the legacy /kad kademlia protocol.

Instead, nodes use the genesis based kademlia protocol for the discovery process.

Part of:

cc @paritytech/networking

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added T0-node This PR/Issue is related to the topic “node”. I5-enhancement An additional feature request. labels Oct 17, 2024
@lexnv lexnv self-assigned this Oct 17, 2024
lexnv and others added 5 commits October 17, 2024 13:23
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@skunert
Copy link
Contributor

skunert commented Oct 17, 2024

From reading the issue #504 it is not 100% clear to me if this is now safe to remove? Do all nodes need to run #3833 for it to be safe?

@lexnv
Copy link
Contributor Author

lexnv commented Oct 17, 2024

Do all nodes need to run #3833 for it to be safe?

Yep that's a good point. Will crawl the DHTs and see if someone is still running legacy only kademlia, meanwhile will add a Do not merge on this pr

@lexnv lexnv changed the title net/discovery: Remove legacy /kad protocol [Do not merge] net/discovery: Remove legacy /kad protocol Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request. T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants