Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409]: Backport #5688 #5727

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[stable2409]: Backport #5688 #5727

merged 1 commit into from
Sep 16, 2024

Conversation

ordian
Copy link
Member

@ordian ordian commented Sep 16, 2024

As requested here: #5688 (comment)

I don't think it need to be backported to 2407, as the issue was not present there yet.

the range should always contain at least 2 values for the benchmark to
work
closes #5680
@ordian ordian added the A3-backport Pull request is already reviewed well in another branch. label Sep 16, 2024
@ordian ordian requested a review from bkontur September 16, 2024 13:44
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@ggwpez ggwpez merged commit a45d203 into stable2409 Sep 16, 2024
201 of 218 checks passed
@ggwpez ggwpez deleted the ao-backport-5688 branch September 16, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants