Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2407] Backport #5581 #5603

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[stable2407] Backport #5581 #5603

merged 2 commits into from
Sep 5, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 5, 2024

Backport #5581 into stable2407 (cc @franciscoaguirre).

@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Sep 5, 2024 •
edited
Loading

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@github-actions github-actions bot mentioned this pull request Sep 5, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 5, 2024
@franciscoaguirre
Clear other messages before dry-run to get only the ones produced dur…
7dd97e4 
…ing (#5581)

The dry-run shows in `forwarded_xcms` all the messages in the queues at
the time of calling the API.
Each time the API is called, the result could be different.
You could get messages even if you dry-run something that doesn't send a
message, like a `System::remark`.

This PR fixes this by clearing the message queues before doing the
dry-run, so the only messages left are the ones the users of the API
actually care about.

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
(cherry picked from commit 8d9ebcd)
@franciscoaguirre franciscoaguirre marked this pull request as ready for review September 5, 2024 14:47
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner September 5, 2024 14:47
@paritytech-review-bot paritytech-review-bot bot requested a review from a team September 5, 2024 14:48
@acatangiu acatangiu merged commit c28ec0f into stable2407 Sep 5, 2024
95 of 179 checks passed
@acatangiu acatangiu deleted the backport-5581-to-stable2407 branch September 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

Assignees

@franciscoaguirre franciscoaguirre

Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatangiu @franciscoaguirre