Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export more from sc-service #5250

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

nazar-pc
Copy link
Contributor

@nazar-pc nazar-pc commented Aug 6, 2024

Follow-up to #4457, looks like more things were missing

@nazar-pc nazar-pc changed the title Export more from sc service Export more from sc-service Aug 6, 2024
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lexnv lexnv requested a review from niklasad1 August 6, 2024 17:59
@niklasad1 niklasad1 added the T0-node This PR/Issue is related to the topic “node”. label Aug 6, 2024
@niklasad1 niklasad1 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into paritytech:master with commit cd1a29f Aug 7, 2024
156 of 161 checks passed
ordian added a commit that referenced this pull request Aug 7, 2024
* master:
  Umbrella crate: exclude chain-specific crates (#5173)
  Bring reference_hardware.json inline with machine used for weights (#5196)
  Snowbridge on Westend (#5074)
  Run semver check even when no prdoc (#5189)
  Export more from sc-service (#5250)
  Update the wishlist leaderboard script to handle PRs (#5256)
@nazar-pc nazar-pc deleted the export-more-from-sc-service branch August 12, 2024 10:18
nazar-pc added a commit to autonomys/polkadot-sdk that referenced this pull request Aug 12, 2024
Follow-up to paritytech#4457, looks
like more things were missing

---------

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
(cherry picked from commit cd1a29f)
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Aug 28, 2024
Follow-up to paritytech#4457, looks
like more things were missing

---------

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants