Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sp_runtime::traits::BadOrigin #5011

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Conversation

jasl
Copy link
Contributor

@jasl jasl commented Jul 13, 2024

It says Will be removed after July 2023 but that's not true 😃

@jasl jasl requested review from athei and a team as code owners July 13, 2024 00:42
@jasl
Copy link
Contributor Author

jasl commented Jul 13, 2024

@bkchr This one is small 😄

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if the deprecated error would actually work.

@bkchr bkchr requested a review from ggwpez July 13, 2024 07:47
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says Will be removed after July 2023 but that's not true 😃

It is true, "after" just means any point after that date. I think it is good to keep backwards compatibility for parachain teams as long as possible.

Can you please still add a prdoc that mentions all crates as patch? We will add some more convenient way of creating prdocs in the future.

@jasl
Copy link
Contributor Author

jasl commented Jul 13, 2024

It says Will be removed after July 2023 but that's not true 😃

It is true, "after" just means any point after that date. I think it is good to keep backwards compatibility for parachain teams as long as possible.

Can you please still add a prdoc that mentions all crates as patch? We will add some more convenient way of creating prdocs in the future.

Added

@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Jul 13, 2024
prdoc/pr_5011.prdoc Outdated Show resolved Hide resolved
@ggwpez ggwpez enabled auto-merge July 13, 2024 20:29
auto-merge was automatically disabled July 13, 2024 21:21

Head branch was pushed to by a user without write access

@jasl
Copy link
Contributor Author

jasl commented Jul 13, 2024

run cargo fmt manually

@bkchr bkchr enabled auto-merge July 15, 2024 09:22
@bkchr bkchr added this pull request to the merge queue Jul 15, 2024
Merged via the queue into paritytech:master with commit 291210a Jul 15, 2024
157 of 161 checks passed
@jasl jasl deleted the refactor-deprecation branch July 15, 2024 11:22
ordian added a commit that referenced this pull request Jul 17, 2024
* master:
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
jpserrat pushed a commit to jpserrat/polkadot-sdk that referenced this pull request Jul 18, 2024
It says `Will be removed after July 2023` but that's not true 😃

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
ordian added a commit that referenced this pull request Jul 18, 2024
* master: (125 commits)
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  ...
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
It says `Will be removed after July 2023` but that's not true 😃

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
ordian added a commit that referenced this pull request Aug 6, 2024
* master: (130 commits)
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants