[NPoS] Some simple refactors to Delegate Staking #4981
Conversation
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Ank4n
changed the title
DelegateStake refactors.
Ank4n
added
R0-silent
There was a problem hiding this comment.
LGMT. However you say in the PR description:
fn update_payee is renamed to fn set_payee in the trait StakingInterface since there is also a call Staking::update_payee which does something completely different.
but Staking::update_payee seems to do pretty much the same, or am I missing something here?
|
| RawOrigin::Signed(stash.clone()).into(), | ||
| RewardDestination::Account(reward_acc.clone()), | ||
| ) | ||
| let ledger = Self::ledger(Stash(stash.clone()))?; |
There was a problem hiding this comment.
does this write back to storage?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
## Changes - `fn update_payee` is renamed to `fn set_payee` in the trait `StakingInterface` since there is also a call `Staking::update_payee` which does something different, ie used for migrating deprecated `Controller` accounts. - `set_payee` does not re-dispatch, only mutates ledger. - Fix rustdocs for `NominationPools::join`. - Add an implementation note about why we cannot allow existing stakers to join/bond_extra into the pool.
Changes
fn update_payeeis renamed tofn set_payeein the traitStakingInterfacesince there is also a callStaking::update_payeewhich does something different, ie used for migrating deprecatedControlleraccounts.set_payeedoes not re-dispatch, only mutates ledger.NominationPools::join.