Remove pallet::getter usage from all pallet-tips

[Aideepakchaudhary]

ISSUE

Link to the issue: #3326
cc @muraca

Deliverables

• [Deprecation] remove pallet::getter usage from all pallet-tips

Test Outcomes

---

Successful tests by running cargo test -p pallet-tips --features runtime-benchmarks

running 26 tests
test tests::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
test benchmarking::bench_retract_tip ... ok
test tests::equal_entries_invariant ... ok
test benchmarking::bench_tip ... ok
test tests::finders_fee_invariant ... ok
test tests::genesis_config_works ... ok
test tests::genesis_funding_works ... ok
test benchmarking::bench_slash_tip ... ok
test tests::reasons_invariant ... ok
test benchmarking::bench_report_awesome ... ok
test tests::close_tip_works ... ok
test tests::report_awesome_from_beneficiary_and_tip_works ... ok
test tests::test_genesis_config_builds ... ok
test tests::test_last_reward_migration ... ok
test benchmarking::bench_tip_new ... ok
test benchmarking::bench_close_tip ... ok
test tests::test_migration_v4 ... ok
test tests::slash_tip_works ... ok
test tests::report_awesome_and_tip_works_second_instance ... ok
test tests::report_awesome_and_tip_works ... ok
test tests::tip_changing_works ... ok
test tests::zero_base_deposit_prohibited - should panic ... ok
test tests::tip_median_calculation_works ... ok
test tests::tip_new_cannot_be_used_twice ... ok
test tests::tip_large_should_fail ... ok
test tests::retract_tip_works ... ok

test result: ok. 26 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

Doc-tests pallet_tips

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

---

Polkadot Address: 16htXkeVhfroBhL6nuqiwknfXKcT6WadJPZqEi2jRf9z4XPY

[shawntabrizi]

@Aideepakchaudhary for this PR to be 100% backwards compatible (for outside dependencies too), please include two new public functions which expose the storage in the same way as the getter.

For example:

impl<T: Config> Pallet<T> {
    pub fn tips(hash: T::Hash) -> Option<OpenTip...> {
        Tips::<T>::get(hash)
    }
}