Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused rustc-hex deps; enable rustc-hex for primitive-types in sp-core #4860

Merged
merged 9 commits into from
Jun 25, 2024
Merged

chore: remove unused rustc-hex deps; enable rustc-hex for primitive-types in sp-core #4860

merged 9 commits into from
Jun 25, 2024

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Jun 21, 2024 •
edited
Loading

Some primitives have impl Hex related traits enabled by rustc-hex feature. People wanna use H256/H160 maybe need these trait impls

@paritytech-review-bot paritytech-review-bot bot requested a review from a team June 21, 2024 13:27
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jun 21, 2024
@bkchr bkchr requested a review from bkontur June 21, 2024 14:08
@bkchr
Copy link
Member

bkchr commented Jun 21, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 21, 2024 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6519987 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-e4f158e7-a61f-48d1-ae93-9c7fb04a3ca9 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 21, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6519987 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6519987/artifacts/download.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6536671

@bkchr bkchr enabled auto-merge June 25, 2024 11:31
@bkchr bkchr added this pull request to the merge queue Jun 25, 2024
Merged via the queue into paritytech:master with commit a406dd5 Jun 25, 2024
154 of 157 checks passed
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@yjhmelody @bkchr @TarekkMA
chore: remove unused rustc-hex deps; enable rustc-hex for primitive-t…
b9f55b3 
…ypes in sp-core (paritytech#4860)

Some primitives have impl Hex related traits enabled by `rustc-hex`
feature. People wanna use H256/H160 maybe need these trait impls

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
@yjhmelody @bkchr
chore: remove unused rustc-hex deps; enable rustc-hex for primitive-t…
7fbe2a7 
…ypes in sp-core (paritytech#4860)

Some primitives have impl Hex related traits enabled by `rustc-hex`
feature. People wanna use H256/H160 maybe need these trait impls

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkontur bkontur bkontur approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yjhmelody @bkchr @paritytech-cicd-pr @bkontur