pallet ranked collective: max member count per rank #4807
Conversation
muharem
added
the
T1-FRAME
| /// Therefore, the limit `m` at rank `x` sets the maximum total member count for rank `x` | ||
| /// and all ranks above. | ||
| /// The `None` indicates no member count limit for the given rank. | ||
| type MaxMemberCount: MaybeConvert<Rank, MemberIndex>; |
There was a problem hiding this comment.
Do we have a default config for this pallet? Would be nice to set this to () to avoid the breaking change.
There was a problem hiding this comment.
No, it does not have. There is also a discussion to use default configs only for tests and maybe common configs for system parachains https://forum.polkadot.network/t/seeking-feedback-on-derive-impl-for-default-configurations-in-pallet-templates/7584
There was a problem hiding this comment.
I think there should still be a trivial implementation of this to reduce copy&paste.
Some struct like UnlimitedMembersPerRank or so that just always returns None.
There was a problem hiding this comment.
MaybeConvert has a tuple implementation, which always returns none
There was a problem hiding this comment.
Oh, so it is possible to just pass ()? Then i misunderstood the discussion, good!
|
bot merge |
|
@muharem |
Configuration for the maximum member count per rank, with the option for no limit.
Configuration for the maximum member count per rank, with the option for no limit.