Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core sharing and make use of scheduling_lookahead #4724

Merged
merged 37 commits into from
Jun 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
b64eb22
Zombienet test for two parachains sharing a core
tdimitrov May 30, 2024
4deb507
fixes
alindima Jun 3, 2024
c94c398
further simplify the fix
alindima Jun 3, 2024
732a74f
prospective-parachains: hack fetch_upcoming_paras
tdimitrov Jun 5, 2024
49193f3
Use claim queue in the validator side of collator protocol
tdimitrov Jun 6, 2024
00eed19
Use claim queue in the collator side of collator protocol
tdimitrov Jun 6, 2024
4ddb874
Use claim queue in `fetch_upcoming_paras` from `prospective-parachains`
tdimitrov Jun 6, 2024
8190687
add prospective parachains tests
alindima Jun 11, 2024
a2f0a25
fix collator side and collator side tests
alindima Jun 11, 2024
b979563
Merge remote-tracking branch 'origin/master' into tsv-ct-core-sharing
alindima Jun 11, 2024
c996a90
clippy
alindima Jun 11, 2024
c874cf1
it works!!
alindima Jun 12, 2024
ec70d6b
Merge remote-tracking branch 'origin/master' into tsv-ct-core-sharing
alindima Jun 12, 2024
b88f4e8
properly fix backing
alindima Jun 12, 2024
8afe82f
fix unit tests
alindima Jun 12, 2024
7050c2e
update comments
alindima Jun 13, 2024
e23187b
add proper zombienet test
alindima Jun 13, 2024
a3560a3
review comments
alindima Jun 17, 2024
2fe2420
symlink assign-core.js
alindima Jun 17, 2024
8f1d8e0
try fixing zombienet
alindima Jun 17, 2024
3469f2d
fix compilation
alindima Jun 17, 2024
889cb32
clippy again
alindima Jun 17, 2024
a4387a2
add prdoc
alindima Jun 17, 2024
8532f7d
try fixing prdoc
alindima Jun 17, 2024
7c1fc91
Merge remote-tracking branch 'origin/master' into tsv-ct-core-sharing
alindima Jun 17, 2024
e85b19f
try fixing zombienet
alindima Jun 17, 2024
4d69a3a
more zombienet
alindima Jun 17, 2024
829af4d
semver
alindima Jun 18, 2024
a6998be
use relative symlinks
alindima Jun 18, 2024
21be690
CI stuff
alindima Jun 18, 2024
2cb6bf2
small review comment
alindima Jun 18, 2024
8f860c1
add copy command to CI file
alindima Jun 18, 2024
e343989
fix gitlab yaml
alindima Jun 18, 2024
69d16cd
lower glutton compute
alindima Jun 18, 2024
4c3635b
Merge remote-tracking branch 'origin/master' into tsv-ct-core-sharing
alindima Jun 18, 2024
9eea0c6
relax zombienet constraint
alindima Jun 18, 2024
9c118cb
don't compute the validator group for an unscheduled core when using …
alindima Jun 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clippy
  • Loading branch information
alindima committed Jun 11, 2024
commit c996a90398ff1d215fdd1cdb71d8a21b3b579671
5 changes: 2 additions & 3 deletions polkadot/node/core/prospective-parachains/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ async fn handle_leaf_activation(
AllMessages::RuntimeApi(
RuntimeApiMessage::Request(parent, RuntimeApiRequest::AvailabilityCores(tx))
) if parent == *hash => {
tx.send(Ok(test_state.claim_queue.iter().map(|(_, paras)| CoreState::Scheduled(
tx.send(Ok(test_state.claim_queue.values().map(|paras| CoreState::Scheduled(
ScheduledCore {
para_id: *paras.front().unwrap(),
collator: None
Expand Down Expand Up @@ -321,8 +321,7 @@ async fn handle_leaf_activation(

for _ in 0..test_state
.claim_queue
.iter()
.map(|(_, paras)| paras)
.values()
.fold(HashSet::new(), |mut acc, paras| {
alindima marked this conversation as resolved.
Show resolved Hide resolved
for para in paras {
acc.insert(*para);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ async fn distribute_collation_with_receipt(
RuntimeApiRequest::AvailabilityCores(tx)
)) => {
assert_eq!(relay_parent, _relay_parent);
tx.send(Ok(test_state.claim_queue.iter().map(|(_, paras)|
tx.send(Ok(test_state.claim_queue.values().map(|paras|
if let Some(para) = paras.front() {
CoreState::Scheduled(ScheduledCore { para_id: *para, collator: None })
} else {
Expand Down
Loading