ci: disallow westend migration failure #4205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
added
the
R0-no-crate-publish-required
bkchr
approved these changes
Apr 19, 2024
Co-authored-by: Bastian Köcher <git@kchr.de>
liamaharon
changed the title
liamaharon
commented
Apr 19, 2024
Comment on lines
-1653
to
-1678
| pub type Unreleased = ( | ||
| parachains_configuration::migration::v7::MigrateToV7<Runtime>, | ||
| pallet_staking::migrations::v14::MigrateToV14<Runtime>, | ||
| assigned_slots::migration::v1::MigrateToV1<Runtime>, | ||
| parachains_scheduler::migration::MigrateV1ToV2<Runtime>, | ||
| parachains_configuration::migration::v8::MigrateToV8<Runtime>, | ||
| parachains_configuration::migration::v9::MigrateToV9<Runtime>, | ||
| paras_registrar::migration::MigrateToV1<Runtime, ()>, | ||
| pallet_referenda::migration::v1::MigrateV0ToV1<Runtime, ()>, | ||
| pallet_grandpa::migrations::MigrateV4ToV5<Runtime>, | ||
| parachains_configuration::migration::v10::MigrateToV10<Runtime>, | ||
| pallet_nomination_pools::migration::unversioned::TotalValueLockedSync<Runtime>, | ||
| // Migrate Identity pallet for Usernames | ||
| pallet_identity::migration::versioned::V0ToV1<Runtime, IDENTITY_MIGRATION_KEY_LIMIT>, | ||
| parachains_configuration::migration::v11::MigrateToV11<Runtime>, | ||
| parachains_configuration::migration::v12::MigrateToV12<Runtime>, | ||
| // permanent | ||
| pallet_xcm::migration::MigrateToLatestXcmVersion<Runtime>, | ||
| // Migrate from legacy lease to coretime. Needs to run after configuration v11 | ||
| coretime::migration::MigrateToCoretime< | ||
| Runtime, | ||
| crate::xcm_config::XcmRouter, | ||
| GetLegacyLeaseImpl, | ||
| >, | ||
| parachains_inclusion::migration::MigrateToV1<Runtime>, | ||
| ); |
There was a problem hiding this comment.
These are all released
There was a problem hiding this comment.
I think pallet_xcm::migration::MigrateToLatestXcmVersion<Runtime> is supposed to stay in, but should probably be in another tuple.
alvicsam
approved these changes
Apr 19, 2024
sandreim
approved these changes
Apr 19, 2024
seadanda
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.