Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BABE README.md #4138

Merged
merged 4 commits into from
May 15, 2024
Merged

Update BABE README.md #4138

merged 4 commits into from
May 15, 2024

Conversation

drewstone
Copy link
Contributor

@drewstone drewstone commented Apr 15, 2024

Link was dead

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove from the know-bad list of links in .config/lychee.toml.

@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Apr 15, 2024
Copy link

Review required! Latest push from author must always be reviewed

@drewstone
Copy link
Contributor Author

Lmk if that's sufficient @ggwpez

@ggwpez
Copy link
Member

ggwpez commented Apr 16, 2024

Looks like it is used in other files as well, could you please also update it there?
You can see the CI output here: https://github.com/paritytech/polkadot-sdk/actions/runs/8696387154/job/23868834750?pr=4138

@bkchr
Copy link
Member

bkchr commented May 14, 2024

@drewstone ^^^

@drewstone
Copy link
Contributor Author

@bkchr updated

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6200601

@bkchr bkchr enabled auto-merge May 14, 2024 22:05
@bkchr bkchr added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 15, 2024
@bkchr bkchr added this pull request to the merge queue May 15, 2024
Merged via the queue into paritytech:master with commit e6d934c May 15, 2024
149 of 150 checks passed
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
Link was dead

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
liuchengxu pushed a commit to liuchengxu/polkadot-sdk that referenced this pull request Jun 19, 2024
Link was dead

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Link was dead

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants