Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grandpa: Send neighbor packet to lightclients with every finalized head #4135

Merged
merged 3 commits into from
Apr 17, 2024
Merged

grandpa: Send neighbor packet to lightclients with every finalized head #4135

merged 3 commits into from
Apr 17, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Apr 15, 2024

This PR sends the GrandpaNeighbor packet to lightclients similarly to the full-nodes.

Previously, the lightclient would receive a GrandpaNeigbor packet only when the note set changed.

Related to: #4120

Next steps:

  • check with lightclient

@lexnv
grandpa: Send neighbor packet to lightclients with every finalized head
6a02220 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
grandpa: Remove force flag for neighbor packet
4fc7a0a 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv self-assigned this Apr 15, 2024
@lexnv lexnv requested a review from andresilva as a code owner April 15, 2024 14:56
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5933440

@andresilva
Copy link
Contributor

Need to change the test sends_neighbor_packets_to_non_light_peers_when_starting_a_new_round to check that all peers (including light clients) receive the neighbor message.

@lexnv lexnv added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes I5-enhancement An additional feature request. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Apr 15, 2024
@lexnv
grandpa/tests: Modify test to validate the lightclient recv neighbor
e763dcf 
message

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

@lexnv lexnv requested a review from a team April 17, 2024 07:00
@lexnv lexnv added this pull request to the merge queue Apr 17, 2024
Merged via the queue into master with commit 8fd839d Apr 17, 2024
134 of 140 checks passed
@lexnv lexnv deleted the lexnv/neighbor-pckt branch April 17, 2024 08:51
@lexnv lexnv mentioned this pull request Apr 17, 2024
Closed
@tomaka tomaka mentioned this pull request Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-markin dmitry-markin dmitry-markin approved these changes

@andresilva andresilva andresilva approved these changes

Assignees

@lexnv lexnv

Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lexnv @paritytech-cicd-pr @andresilva @dmitry-markin