Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts: add test builders #3796

Merged
merged 12 commits into from
Mar 28, 2024
Merged

Contracts: add test builders #3796

merged 12 commits into from
Mar 28, 2024

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Mar 22, 2024

Cleanup tests (-2.7k lines !) using some builder patterns to build pallet_contracts api calls

@pgherveou pgherveou added the R0-silent Changes should not be mentioned in any release notes label Mar 22, 2024
@pgherveou pgherveou marked this pull request as ready for review March 22, 2024 23:36
@pgherveou pgherveou requested a review from athei as a code owner March 22, 2024 23:36
Copy link
Contributor

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup, love the reduced amount of code to write new tests!

@pgherveou pgherveou disabled auto-merge March 28, 2024 10:24
@pgherveou pgherveou added this pull request to the merge queue Mar 28, 2024
Merged via the queue into master with commit 78b1cab Mar 28, 2024
127 of 132 checks passed
@pgherveou pgherveou deleted the pg/test_builders branch March 28, 2024 12:08
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
Cleanup tests (-2.7k lines !) using some builder patterns to build
pallet_contracts api calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants