Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on latest nightly because of stdsimd #3296

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Feb 12, 2024

We need to bump ahash to make it compile again.

Closes: #3269

We need to bump `ahash` to make it compile again.
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Feb 12, 2024
@bkchr bkchr requested a review from ggwpez February 12, 2024 14:34
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So they just fixed it in a patch version, although its a breaking change.
Nice 😆

@bkchr
Copy link
Member Author

bkchr commented Feb 12, 2024

So they just fixed it in a patch version, although its a breaking change. Nice 😆

They used some nightly feature, which they should not be doing 🙈

@bkchr bkchr requested a review from a team as a code owner February 12, 2024 15:37
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5191117

@bkchr bkchr added this pull request to the merge queue Feb 13, 2024
Merged via the queue into master with commit 349132f Feb 13, 2024
123 of 125 checks passed
@bkchr bkchr deleted the bkchr-fix-ahash branch February 13, 2024 13:53
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
We need to bump `ahash` to make it compile again.

Closes: paritytech#3269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIMD removal from rust
5 participants