Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport XCM fixes to 1.5.0 #3174

Merged
merged 10 commits into from
Feb 8, 2024

Commits on Feb 1, 2024

  1. xcm-executor: DepositReserveAsset charges delivery fees from inner as…

    …sets (#3142)
    
    This fix aims to solve an issue in Kusama that resulted in failed
    reserve asset transfers.
    
    During multi-hop XCMs, like reserve asset transfers where the reserve is
    not the sender nor the destination, but a third remote chain, the origin
    is not available to pay for delivery fees out of their account directly,
    so delivery fees should be paid out of transferred assets.
    
    This commit also adds an xcm-emulator regression test that validates
    this scenario is now working.
    
    Signed-off-by: Adrian Catangiu <adrian@parity.io>
    Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
    acatangiu and franciscoaguirre committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4c5e93b View commit details
    Browse the repository at this point in the history
  2. Transactional processing for XCM (#1222)

    Moved from: paritytech/polkadot#6951
    
    closes #490
    
    - [x] update cumulus
    
    ---
    This PR introduces transactional processing of certain xcm instructions.
    For the list of instructions checkout
    #490. The transactional
    processing is implemented as an xcm-executor config item. The two
    implementations in this PR are `FrameTransactionalProcessor` and `()`.
    The `()` implementation does no transactional processing. Each
    implementation of the `ProcessTransaction` trait has an
    `IS_TRANSACTIONAL` const that tells the XCVM if transactional processing
    is actually implemented. If Transactional processing is implemented,
    changes to touched registers should also be rolled back to prevent
    inconsistencies.
    
    Note for reviewers:
    Check out the following safety assumption:
    https://github.com/paritytech/polkadot-sdk/pull/1222/files#diff-4effad7d8c1c9de19fd27e18661cbf2128c8718f3b2420a27d2f816e0749ea53R30
    
    ---------
    
    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
    Co-authored-by: command-bot <>
    3 people committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e0bc77e View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    ccd0634 View commit details
    Browse the repository at this point in the history
  2. Fixes

    franciscoaguirre committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    667a484 View commit details
    Browse the repository at this point in the history
  3. Fixes

    franciscoaguirre committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1dc6dcc View commit details
    Browse the repository at this point in the history
  4. pallet-xcm: fix test benchmarks (#2679)

    For some reason original PR passed CI - when it shouldn't have. Fix
    `pallet-xcm` test benchmarks.
    acatangiu authored and franciscoaguirre committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    5eb4171 View commit details
    Browse the repository at this point in the history
  5. [ci] Update rust to 1.74 (#2545)

    cc paritytech/ci_cd#900
    
    ---------
    
    Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    Co-authored-by: Dónal Murray <donal.murray@parity.io>
    Co-authored-by: Bastian Köcher <info@kchr.de>
    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    Co-authored-by: command-bot <>
    4 people authored and franciscoaguirre committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    526be44 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    56f25ed View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Fix markdown lint error (#3104)

    pgherveou authored and bkontur committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cb78e33 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Small fix

    franciscoaguirre committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b15ea9e View commit details
    Browse the repository at this point in the history