Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw Assets Before Checking Out in OnReapIdentity impl #2552

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Withdraw Assets Before Checking Out in OnReapIdentity impl #2552

merged 7 commits into from
Nov 30, 2023

Commits on Nov 29, 2023

  1. actually withdraw assets before checking out

    @joepetrowski
    joepetrowski committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    140a5e8 View commit details
    Browse the repository at this point in the history

  2. don't break error encoding

    @joepetrowski
    joepetrowski committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    76c42e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Adrian Catangiu <adrian@parity.io>
    @joepetrowski @acatangiu
    joepetrowski and acatangiu authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7002eb0 View commit details
    Browse the repository at this point in the history

  2. log error messages

    @joepetrowski
    joepetrowski committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a2a041f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into joe-fix-onreapidentity

    @liamaharon
    liamaharon authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    50de3d9 View commit details
    Browse the repository at this point in the history

  4. remove new error variant

    @joepetrowski
    joepetrowski committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d238c21 View commit details
    Browse the repository at this point in the history

  5. add comment about transactional context

    @joepetrowski
    joepetrowski committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c4b7970 View commit details
    Browse the repository at this point in the history