-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ExportGenesisStateCommand
to ExportGenesisHeadCommand
and make it respect custom genesis block builders
#2331
Changes from 1 commit
6fb2596
89e825b
238a7e0
59b2c8f
f58981e
3caefa5
08365ff
d456cd0
7c84b90
5e20abc
c72c161
e4ac486
ece683a
cca6d02
1b593f7
a8e8fb1
439a5d4
297e1bd
1f6a2f3
757dc51
85d39ac
c187e00
22136dc
35d9518
01dd857
68d858f
8f2f471
81f5dfd
554fcb3
e8d4327
babcd27
30a55f8
e1566bc
50f7f47
31f8a2c
fe5b9f4
df69620
f7c04de
6bc796d
238c874
89511b6
c41f8a4
c19c29d
58a75ea
a37a3d4
aa3d14a
0c9dbc2
3c39cc9
8da60f6
1e528ee
4866c84
1d5795b
0a21af5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please replace the state version extraction by this, then we can merge for now 👍 let wasm_executor: WasmExecutor<sp_io::SubstrateHostFunctions> =WasmExecutor::builder().build();
let state_version = sc_chain_spec::resolve_state_version_from_wasm(
&spec.build_storage()?,
&wasm_executor,
)?; There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure why we have the custom export logic there any way. We can just call the default code for @JoshOrndorff can you please do this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry for the delay. I've done it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DQ: Why do we need to preserve this logic for the test node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is called in two places. I briefly considered how to eliminate it entirely, but I wasn't familiar enough with the test service. If you have an idea, I think it would be nice to eliminate this entirely. But this already fixes a real bug for me, so if this cleanup gets too complex, maybe we can do it in a followup.