Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom error message for StorageNoopGuard #1727

Merged
merged 13 commits into from
Sep 27, 2023
Merged

Add custom error message for StorageNoopGuard #1727

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
45bc809
Add custom error messages for StorageNoopGuard
seadanda Sep 27, 2023
40319f0
Add new() alias to default() for StorageNoopGuard
seadanda Sep 27, 2023
bad96b0
Fix doc comments
seadanda Sep 27, 2023
332d26f
Update default error message
seadanda Sep 27, 2023
9c90e7b
Properly link StorageNoopGuard in doc comments
seadanda Sep 27, 2023
e612f81
Implement From str for StorageNoopGuard
seadanda Sep 27, 2023
7bc5b61
Remove From implementation
seadanda Sep 27, 2023
182f6ee
Change type of the error message to String
seadanda Sep 27, 2023
aeeeb2d
Merge branch 'master' into donal-improve-storage-noop-guard
seadanda Sep 27, 2023
b5bbaa1
Revert "Change type of the error message to String"
seadanda Sep 27, 2023
42d568d
Switch str lifetime from static to same as guard
seadanda Sep 27, 2023
e207064
Merge branch 'master' into donal-improve-storage-noop-guard
seadanda Sep 27, 2023
ac27122
Merge branch 'master' into donal-improve-storage-noop-guard
seadanda Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove From implementation
  • Loading branch information
@seadanda
seadanda committed Sep 27, 2023
commit 7bc5b6157c19d2cfa7838cfefbecdb165ad2ae88
16 changes: 0 additions & 16 deletions substrate/frame/support/src/storage/storage_noop_guard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ impl Default for StorageNoopGuard {
}
}

impl From<&'static str> for StorageNoopGuard {
fn from(error_message: &'static str) -> Self {
StorageNoopGuard { storage_root: sp_std::vec::Vec::new(), error_message }
}
}

impl StorageNoopGuard {
/// Alias to `default()`.
pub fn new() -> Self {
Expand Down Expand Up @@ -153,16 +147,6 @@ mod tests {
});
}

#[test]
#[should_panic(expected = "`StorageNoopGuard` found unexpected storage changes.")]
fn storage_noop_guard_panics_created_from() {
TestExternalities::default().execute_with(|| {
let _guard =
StorageNoopGuard::from("`StorageNoopGuard` found unexpected storage changes.");
frame_support::storage::unhashed::put(b"key", b"value");
});
}

#[test]
#[should_panic(expected = "`StorageNoopGuard` found unexpected storage changes.")]
fn storage_noop_guard_panics_with_set_error_message() {
Expand Down