Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable async backing on Rococo #1496

Closed
wants to merge 1 commit into from
Closed

Conversation

Sophia-Gold
Copy link
Contributor

@Sophia-Gold Sophia-Gold commented Sep 11, 2023

This enables async backing in the Rococo runtime.

Requires #1543 and #1542.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3650532

@@ -1714,6 +1714,7 @@ sp_api::impl_runtime_apis! {
}
}

#[api_version(99)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem. We can not have a release with version 99. We have to pick a proper version, which has consequences (which should be fine): We have to release this API next in production. We can then no longer release any other new functionality without also releasing async backing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more correct: We have to determine now what the next version is exactly. By making it no longer 99, this version is stable and must no longer be changed/modified in any way without bumping the version again.

Copy link
Contributor

@rphmeier rphmeier Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we need is a way to stabilize the API version without automatically upgrading all runtimes to it

@Sophia-Gold
Copy link
Contributor Author

Closing in favor of #1543.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants