-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup repo (a tiny bit) #1382
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@@ -1,24 +0,0 @@ | |||
# Basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serban300
could you, please, exclude this file from verify-pallets-build.sh
in bridges repo?
Just to avoid bringing it back on the next subtree update.
Anyway, I will file a issue soon for moving bridges to the monorepo and move subtree from cumulus subdirectory out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the need to ignore *.adoc
. There are probably not many left.
Thanks for the cleanup !
@@ -7,6 +7,7 @@ | |||
.local | |||
.vscode | |||
.wasm-binaries | |||
*.adoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not ignore the adoc files but removing them as you did is great.
Most are very old.
A (long) while ago, I introduced adoc to substrate mainly because it supports include
.
A point was made however back then: Rust means Markdown and there is no foreseen support for adoc so using adoc for the documentation of a Rust project adds some burden that it not worth going thru when we ned a simple README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed all adocs. The gitignore was meant as a warning for devs to not accidentially commit adocs again 😄 (since git prints something if you try to commit a gitignored file)
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Delete stale adoc files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Convert adoc to md Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add adoc to gitignore Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Delete more random unmaintained files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Markdown lint Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Delete stale adoc files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Convert adoc to md Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add adoc to gitignore Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Delete more random unmaintained files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Markdown lint Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Delete stale adoc files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Convert adoc to md Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add adoc to gitignore Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Delete more random unmaintained files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Markdown lint Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Saw some random unmaintained files… outdated docs do more harm than good IMO.
The repo could use some proper scrubbing but i only deleted the ones that i bumped into for now.