Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GoAhead signal only set when runtime upgrade is enacted from parachain side #1176

Merged
merged 7 commits into from
Oct 15, 2023
Merged

fix: GoAhead signal only set when runtime upgrade is enacted from parachain side #1176

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
21570c6
reapply changes
Daanvdplas Sep 11, 2023
08407df
clean up merge conflicts
Daanvdplas Sep 11, 2023
688bf7e
fix
Daanvdplas Sep 11, 2023
e3dcd32
cargo +nightly fmt
Daanvdplas Sep 11, 2023
c020453
Update polkadot/runtime/parachains/src/paras/tests.rs
bkchr Oct 15, 2023
c30aff9
Merge branch 'master' into daan/fix-go-ahead-signal
bkchr Oct 15, 2023
3740bbe
Fix benchmarks
bkchr Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@Daanvdplas
Daanvdplas committed Sep 11, 2023
commit 688bf7e56bf144850cf322575d39afa9190a1e67
6 changes: 3 additions & 3 deletions polkadot/runtime/parachains/src/paras/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,8 +1550,8 @@ impl<T: Config> Pallet<T> {
PvfCheckCause::Onboarding(id) => {
weight += Self::proceed_with_onboarding(*id, sessions_observed);
},
PvfCheckCause::Upgrade { id, included_at } => {
weight += Self::proceed_with_upgrade(*id, code_hash, now, *included_at, cfg);
PvfCheckCause::Upgrade { id, included_at, set_go_ahead } => {
weight += Self::proceed_with_upgrade(*id, code_hash, now, *included_at, cfg, *set_go_ahead);
},
}
}
Expand Down Expand Up @@ -1905,7 +1905,7 @@ impl<T: Config> Pallet<T> {
});

weight += Self::kick_off_pvf_check(
PvfCheckCause::Upgrade { id, included_at: inclusion_block_number },
PvfCheckCause::Upgrade { id, included_at: inclusion_block_number, set_go_ahead },
code_hash,
new_code,
cfg,
Expand Down