Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the improved_panic_error_reporting feature in sp-io for our runtimes in a few releases #869

Open
koute opened this issue Feb 9, 2022 · 6 comments
Open

Enable the improved_panic_error_reporting feature in sp-io for our runtimes in a few releases #869

koute opened this issue Feb 9, 2022 · 6 comments
Assignees
@koute
Labels
I5-enhancement An additional feature request. T0-node This PR/Issue is related to the topic “node”. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@koute
Copy link
Contributor

koute commented Feb 9, 2022

Substrate PR: paritytech/substrate#10741
Background issue: paritytech/substrate#10585

We should wait for a few releases until people have upgraded their clients (so that the new required host function is available) and then switch this feature on.
@dvdplm
Copy link
Contributor

dvdplm commented Jun 13, 2022

dq: what does "enable" actually mean here? Does this need a Polkadot PR?

@bkchr
Copy link
Member

bkchr commented Jun 13, 2022

Yes, there is a feature that needs to be activated. I think it can be done now, but there is no real need to get it done for the next release.

@ordian
Copy link
Member

ordian commented Nov 22, 2022

Does fixing this also fix paritytech/substrate#11828?

@bkchr
Copy link
Member

bkchr commented Nov 22, 2022

Yes, as I have commented on the issue.

@koute it is now finally time to enable this :P I think we can just remove the feature and have it enabled always.

@koute
Copy link
Contributor Author

koute commented Nov 22, 2022

Indeed; this was included in Polkadot 0.9.17, and the newest version that explicitly pops up in our telemetry is 0.9.24, so should be fine to enable it.

I'll push a PR tomorrow morning.

@koute koute self-assigned this Nov 22, 2022
@bkchr
Copy link
Member

bkchr commented Nov 22, 2022

Thank you. Important here being any way that all validators support this and they support this for sure.

@the-right-joyce the-right-joyce added T0-node This PR/Issue is related to the topic “node”. T1-runtime labels Dec 14, 2022
@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed B1-note_worthy labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@alistair-singh
New xcm format (paritytech#869)
a9fea07 
* parse new xcm format

* fmt

* rename

* fixed tests to pass None as account key network

* rustfmt

* removed more network checks

* allow none locations

* fixed tests

* fixed asset resolution

* partial

* use locations

* updated cumulus

* fix test

* increase coverage

* rustfmt

* fix coverage

* covering tests

* more coverage

* more coverage

* more fixes

* coverage

* return correct error

* update cumulus

* fix test
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@tomusdrw
Extract select_bridge macro. (paritytech#869)
373b534
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@tomusdrw
Extract select_bridge macro. (paritytech#869)
e212ea2
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw
Extract select_bridge macro. (paritytech#869)
dbcdb1b
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
8ad6333
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
b0206b4
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
83a22e9
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
f7cbc7b
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
795dace
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
0fcf136
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
f51e3bf
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
2784653
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
6c0222e
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
ea814b1
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
ca6a6c0
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@tomusdrw @serban300
Extract select_bridge macro. (paritytech#869)
6651d10
bkchr pushed a commit that referenced this issue Apr 10, 2024
@tomusdrw @bkchr
Extract select_bridge macro. (#869)
ed5577b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koute koute

Labels
I5-enhancement An additional feature request. T0-node This PR/Issue is related to the topic “node”. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dvdplm @koute @ordian @bkchr @the-right-joyce