Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polling from PVF preparation memory tracker #719

Open
mrcnski opened this issue Feb 8, 2023 · 5 comments
Open

Remove polling from PVF preparation memory tracker #719

mrcnski opened this issue Feb 8, 2023 · 5 comments

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Feb 8, 2023

I think a better way to handle this would be to not poll and instead set up a cgroup with an appropriate limit and subscribe to an event once that limit is breached.

Originally posted by @koute in paritytech/polkadot#6565 (comment)

My comment: I'll keep the polling for now, for the purposes of gathering metrics, as we don't yet know what the limit should be. Once we know, we'll be able to implement this suggestion.

Related issue

#718

@daredevil3435

This comment was marked as off-topic.

@mrcnski

This comment was marked as off-topic.

@mrcnski mrcnski removed the J7-mentor label Apr 13, 2023
@mrcnski
Copy link
Contributor Author

mrcnski commented Apr 13, 2023

Also, the current issue requires some further research, so I removed the mentor tag here.

@daredevil3435

This comment was marked as off-topic.

@mrcnski

This comment was marked as off-topic.

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
* Use Option for initial_sync in GenesisConfig

* Fix import path

This was blocking the E2E tests (both bootstrap and the full suite).
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
…ritytech#719)

* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
bkchr pushed a commit that referenced this issue Apr 10, 2024
* keep multiple latest confirmed nonces at source in messages relay

* post-merge fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants