You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current PoV request timeout is set to 1.2s because of synchronous backing. There we have a very small overall time budget. This is no longer true for asynchronous backing.
Considering that this is a hard timeout where we completely drop the response if exceeded, it might make sense to think about bumping it a bit. This would add robustness, especially with concurrent requests. Given that a single fetch should take around 200ms it probably is still ok. But there is no harm in bumping though. If we have 10 parallel requests, than the timeout should be around 2s.
In any case let's test this with Gluttons on Kusama, Lot's of 10MB PoVs ... let's see what happens.
# Description
We previously set the PoV request timeout to 1.2s based on synchronous
backing, which allowed for 5 PoVs per relay block. With asynchronous
backing, we no longer have a time budget and can increase the value to
2s.
Fixes#5885
## Integration
This PR shouldn't affect downstream projects.
## Review Notes
This PR can be followed by experiments with Gluttons on Kusama to
confirm that the timeout is sufficient.
The current PoV request timeout is set to 1.2s because of synchronous backing. There we have a very small overall time budget. This is no longer true for asynchronous backing.
Considering that this is a hard timeout where we completely drop the response if exceeded, it might make sense to think about bumping it a bit. This would add robustness, especially with concurrent requests. Given that a single fetch should take around 200ms it probably is still ok. But there is no harm in bumping though. If we have 10 parallel requests, than the timeout should be around 2s.
In any case let's test this with Gluttons on Kusama, Lot's of 10MB PoVs ... let's see what happens.
Edited comment by @eskimor in #5753 (comment)
The text was updated successfully, but these errors were encountered: