Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Statement Distribution V2/V3 Metrics #4334

Open
3 tasks
Overkillus opened this issue Apr 30, 2024 · 1 comment
Open
3 tasks

Add Statement Distribution V2/V3 Metrics #4334

Overkillus opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@Overkillus
Copy link
Contributor

Overkillus commented Apr 30, 2024

Statement Distribution has those metrics registered:

        statements_distributed: prometheus::Counter<prometheus::U64>,
	sent_requests: prometheus::Counter<prometheus::U64>,
	received_responses: prometheus::CounterVec<prometheus::U64>,
	active_leaves_update: prometheus::Histogram,
	share: prometheus::Histogram,
	network_bridge_update: prometheus::HistogramVec,
	statements_unexpected: prometheus::CounterVec<prometheus::U64>,
	created_message_size: prometheus::Gauge<prometheus::U64>,

After the switch to V2 the metrics were not properly updated and they are not used in V2/V3. Only active_leaves_update and share are being reported in the V2/V3 protocol. Other metrics are only reported when using the legacy V1.

TODOs:

  • Mark with comments (or maybe there's a nicer way?) which metrics are used by which version (v1/2/3)
  • Add new metrics tailored to v2 (preferably new metrics instead of subscribing to the old ones)
  • And new metrics relevant to v3

Note:
PR #3444 Adds 2 more metrics not mentioned here relevant to v2 that tracks requests dropped due to peer limiting and the number of times we reach max parallel requests limit.

@Overkillus Overkillus added T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Apr 30, 2024
@AndreiEres
Copy link
Contributor

I'm going to take this one because I may need more metrics for statemant-distribution benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants