Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polkadot-parachain v1.10.0 breaks collating on polkadot system chains #4067

Closed
2 tasks done
stakeworld opened this issue Apr 10, 2024 · 7 comments · Fixed by #4070
Closed
2 tasks done

polkadot-parachain v1.10.0 breaks collating on polkadot system chains #4067

stakeworld opened this issue Apr 10, 2024 · 7 comments · Fixed by #4070
Assignees
Labels
I2-bug The node fails to follow expected behavior.

Comments

@stakeworld
Copy link
Contributor

stakeworld commented Apr 10, 2024

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

After updating polkadot-parachain from 1.9.0 to 1.10.0 the collator stops producing blocks and in the logs throws the following error every 6 seconds:
Apr 10 13:35:06 polkadot-parachain[1787724]: 2024-04-10 13:35:06 [Relaychain] failed to handle new activations err=Runtime(NotSupported { runtime_api_name: "para_backing_state" })

Apr 10 13:35:13 polkadot-parachain[1787724]: 2024-04-10 13:35:13 [Relaychain] failed to handle new activations err=Runtime(NotSupported { runtime_api_name: "para_backing_state" })

Reverting the relay chain (polkadot) to 1.9.0 didn't fix, reverting polkadot-parachain to 1.9.0 fixed the problem.

Steps to reproduce

Updating polkadot and polkadot-parachain to 1.10.0 on an active collator

@stakeworld stakeworld added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Apr 10, 2024
@stakeworld
Copy link
Contributor Author

stakeworld commented Apr 10, 2024

The invulnerable parity collators are probably already updated and are not producing blocks. Also I notice some strange double last blocks in the collators list were two collators have the same last block? Not sure if it is related.
image

@PierreBesson
Copy link

I confirm this is happening to Parity collators running 1.10.

@sandreim
Copy link
Contributor

sandreim commented Apr 10, 2024

#3795 broke it. The missing API is introduced by async backing which is unfortunately not present on Polkadot. I will work on a fix. In the mean time, it should be fine to switch back to polkadot-parachain 1.9.0

@bkchr bkchr removed the I10-unconfirmed Issue might be valid, but it's not yet known. label Apr 10, 2024
@eskimor
Copy link
Member

eskimor commented Apr 10, 2024

I believe integration tests are in the works somewhere? Would they cover things like this in the future?

@sandreim
Copy link
Contributor

I believe integration tests are in the works somewhere? Would they cover things like this in the future?

We'd need to pull polkadot runtime from fellowship repo and have a zombienet test in this repo.

@eskimor
Copy link
Member

eskimor commented Apr 10, 2024

yeah, but the problem is actually that the network is still running the old runtime.

So we need to have an integration test in polkadot-sdk to test with the currently live runtime (can be fetched from chain) (and ideally with any released, but not yet launched one). And in the fellowship, we should do the same prior to release with the currently released node.

I think we need it both ways, otherwise issues will slip. E.g. having that integration test in the fellowship runtime repo would not have caught this issue.

github-merge-queue bot pushed a commit that referenced this issue Apr 11, 2024
…ancient (#4070)

fixes #4067

Also add an early bail out for look ahead collator such that we don't
waste time if a CollatorFn is not set.

TODO:
- [x] add test.
- [x] Polkadot System Parachain burn-in.

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
EgorPopelyaev pushed a commit that referenced this issue Apr 11, 2024
…ancient (#4070)

fixes #4067

Also add an early bail out for look ahead collator such that we don't
waste time if a CollatorFn is not set.

TODO:
- [x] add test.
- [x] Polkadot System Parachain burn-in.

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Copy link
Contributor

Fix is in hotfix release v1.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior.
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants