Skip to content

Revisit usages of binary_search in containers that can contain duplicates #318

Closed
@kianenigma

Description

@kianenigma

The recent events has thought us the hard way that we should not use binary search if a container can have duplicates. The society pallet is a good example of what should be done if there are duplicates: https://github.com/paritytech/substrate/blob/master/frame/society/src/lib.rs#L1205

Metadata

Metadata

Assignees

No one assigned

    Labels

    I4-refactorCode needs refactoring.T1-FRAMEThis PR/Issue is related to core FRAME, the framework.

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions