Skip to content

pallet-xcm: benchmarks are broken for reserve asset transfer and teleport extrinsics #2055

@acatangiu

Description

@acatangiu

Problem

pallet-xcm/benchmarking.rs does not verify any of the benchmarked extrinsics and just blindly assumes they are successful and proceeds to measure their weight.

asset transfer extrinsics benchmarks (possibly others too) are broken however as the extrinsics fail very early on and this failure case is actually benchmarked instead of the full/successful run.

Solution

  • change benchmarks to make extrinsics succeed (where intended),
  • add verify clauses to benchmarks to ensure expected extrinsic side-effects.

Metadata

Metadata

Assignees

Labels

I2-bugThe node fails to follow expected behavior.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions