Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require --force-authoring any more. (#1) #143

Closed
wants to merge 1 commit into from
Closed

Don't require --force-authoring any more. (#1) #143

wants to merge 1 commit into from

Conversation

jimmychu0807
Copy link

@shawntabrizi minor fix

@shawntabrizi
Copy link
Member

Is there somewhere that notes why this flag is not needed anymore?

@bkchr
Copy link
Member

bkchr commented Oct 11, 2021

--force-authoring is only required when you only run one node.

@shawntabrizi
Copy link
Member

--force-authoring is only required when you only run one node.

So this PR is not 100% right. We should have some logic checking how many nodes are configured to run and add the flag when appropriate?

@bkchr
Copy link
Member

bkchr commented Oct 11, 2021

Yes, that sounds better.

While the best would be to remove this cli flag completly from Substrate, but this is something out of scope :P

@jimmychu0807
Copy link
Author

jimmychu0807 commented Oct 12, 2021

I see. So do we want polkadot-launch to automate this, adding --force-authoring when there is only one parachain node, or telling users to do that manually?

I will close this PR, and create an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants