Prevent serde from bringing in std unless the std feature is enabled for this crate
#499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Aug 16, 2023
Cargo.toml
Outdated
| @@ -11,7 +11,7 @@ rust-version = "1.60.0" | |||
|
|
|||
| [dependencies] | |||
| arrayvec = { version = "0.7", default-features = false } | |||
| serde = { version = "1.0.183", optional = true } | |||
| serde = { version = "1.0.183", default-features = false, features = ["alloc", "derive"], optional = true } | |||
There was a problem hiding this comment.
So we dont actually need the alloc and derive features at all?
There was a problem hiding this comment.
Interesting, potentially no. This got me looking into how serde is used and it looks like it's actually gated by the std feature?
https://github.com/paritytech/parity-scale-codec/blob/master/src/compact.rs#L195-L196
Seems like that should change
There was a problem hiding this comment.
I pushed a change that always includes serde, even if std isn't enabled. I think that should work...
bkchr
approved these changes
Aug 17, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
ggwpez
approved these changes
Aug 17, 2023
|
@eranrund did you checked that it still compiles? |
I did, not seeing any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue using this crate in a
no_stdbuild where I wanted to haveserdeenabled, but withoutstd. The change here addresses that.Thank you!